Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed IAsyncDisposable from CachingTransport #3179

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

jamescrosswell
Copy link
Collaborator

Resolves #3178

#skip-changelog

@bitsandfoxes
Copy link
Contributor

I'm not sure I get what's going on there. Is this due to us dropping ns2.0? Is removing the interface the right move here, especially since it seems to work on different TFWs? Can we #if around this if this is a target framework issue?

@jamescrosswell
Copy link
Collaborator Author

I'm not sure I get what's going on there. Is this due to us dropping ns2.0? Is removing the interface the right move here, especially since it seems to work on different TFWs? Can we #if around this if this is a target framework issue?

I'm not sure what's going on either... technically that interface should be included in net5.0 and later. The tests fail on net6.0 and net7.0. I think it's something to do with the version of Microsoft.Bcl.AsyncInterfaces that is expected.

However, we don't use or need that interface. If we drop it, it has no impact. If we keep it, our tests fail on a Windows clean build. I figured in the interests of simplicity then, we just drop it. It gives us no benefits and conversely it creates problems we don't need to solve.

@jamescrosswell jamescrosswell merged commit d64358e into main Mar 4, 2024
30 checks passed
@jamescrosswell jamescrosswell deleted the fix/asyncinterface-windows branch March 4, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not load file or assembly Microsoft.Bcl.AsyncInterfaces when building Sentry on Windows
2 participants