Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change signature order in DiagnosticLogger for exceptions #2715

Merged
merged 3 commits into from Oct 12, 2023
Merged

Change signature order in DiagnosticLogger for exceptions #2715

merged 3 commits into from Oct 12, 2023

Conversation

bitsandfoxes
Copy link
Contributor

Resolves #699

jamescrosswell
jamescrosswell reviewed Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left a couple of comments about consolidating some of the overloads... there are more opportunities than the two I pointed out but figured that was obvious 😉

@jamescrosswell jamescrosswell added this to the 4.0.0 milestone Oct 11, 2023
@bitsandfoxes bitsandfoxes self-assigned this Oct 12, 2023
@bitsandfoxes bitsandfoxes merged commit 4fa245b into feat/4.0.0 Oct 12, 2023
2 of 6 checks passed
@bitsandfoxes bitsandfoxes deleted the ref/log-exceptions branch October 12, 2023 09:57
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Change signature order in `DiagnosticLogger` for exceptions ([#2715](https://github.com/getsentry/sentry-dotnet/pull/2715))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 1952fb4

vaind pushed a commit that referenced this pull request Oct 14, 2023
@bitsandfoxes @vaind
Change signature order in DiagnosticLogger for exceptions (#2715)
e11f3fb
@bitsandfoxes bitsandfoxes mentioned this pull request Oct 23, 2023
Closed
This was referenced Nov 16, 2023
Merged
Draft
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamescrosswell jamescrosswell jamescrosswell approved these changes

Assignees

@bitsandfoxes bitsandfoxes

Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bitsandfoxes @jamescrosswell