Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Native iOS Support #1829

Merged
merged 26 commits into from Aug 2, 2022
Merged

Add Native iOS Support #1829

merged 26 commits into from Aug 2, 2022

Conversation

mattjohnsonpint
Copy link
Contributor

@mattjohnsonpint mattjohnsonpint commented Jul 30, 2022

Add platform support for the net6.0-ios target by bundling the Sentry Cocoa SDK.

More to do later, as indicated by comments, but this all works.

Note, we require a Mac to build these targets. I tried enabling "Pair to Mac" and building on Windows, but there are a lot of gotchas. We can resolve that later.

@mattjohnsonpint
Copy link
Contributor Author

Looks like the build server is trying to restore the workloads incorrectly. I'll fix that.

@mattjohnsonpint mattjohnsonpint marked this pull request as draft July 30, 2022 22:13
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this landing

@mattjohnsonpint mattjohnsonpint marked this pull request as ready for review August 1, 2022 22:12
@mattjohnsonpint
Copy link
Contributor Author

Passing the build now, but I had to disable the Mac Catalyst target for now.
See getsentry/sentry-cocoa#2031

@mattjohnsonpint mattjohnsonpint marked this pull request as draft August 1, 2022 22:17
@mattjohnsonpint
Copy link
Contributor Author

Actually, I'm going to move the Android changes to their own PR for cleanliness.

@mattjohnsonpint
Copy link
Contributor Author

Ok, ready now.

@mattjohnsonpint mattjohnsonpint marked this pull request as ready for review August 1, 2022 23:24
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff. Thanks Matt

@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) August 2, 2022 00:19
@mattjohnsonpint mattjohnsonpint merged commit 1cb066b into main Aug 2, 2022
@mattjohnsonpint mattjohnsonpint deleted the ios-bindings branch August 2, 2022 00:42
@mattjohnsonpint mattjohnsonpint mentioned this pull request Aug 2, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants