Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Transaction as aborted when unhandled exception occurs #1996

Merged
merged 11 commits into from Oct 20, 2022
Merged

Mark Transaction as aborted when unhandled exception occurs #1996

merged 11 commits into from Oct 20, 2022

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Oct 17, 2022 •
edited by mattjohnsonpint

Fixes #1975

@SimonCropp SimonCropp marked this pull request as draft October 17, 2022 03:07
@mattjohnsonpint mattjohnsonpint mentioned this pull request Oct 17, 2022
Open
5 tasks
@mattjohnsonpint
Copy link
Contributor

@SimonCropp - not sure if you wanted to add anything else here, or if you're good with my changes. Please review. Thanks. 😄

@SimonCropp SimonCropp marked this pull request as ready for review October 20, 2022 01:41
@SimonCropp
Copy link
Contributor Author

rebased on main, and one small thing fixed. out of draft now

@mattjohnsonpint mattjohnsonpint merged commit 0de6a00 into main Oct 20, 2022
@mattjohnsonpint mattjohnsonpint deleted the mark-trans-as-aborted-when-unhandled-ex branch October 20, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjohnsonpint mattjohnsonpint mattjohnsonpint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Closing Unfinished Transactions
2 participants
@SimonCropp @mattjohnsonpint