-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish and capture transaction/span bound to the Scope in case of a fatal crash-shutdown (eg Java Unhandled exception) #443
Comments
cc @rhcarvalho @AbhiPrasad @mitsuhiko in case you know which SDKs should do it as well, please edit the description so we can track it |
In sentry-cocoa it would require serializing the data into the SentryCrash state so it gets dumped on a crash so not super trivial. Mainly because of the overhead it'll add since any change in the transaction would require serialization. On SDKs that have a runtime like |
On Dart Flutter never crashes so we don't need to do anything. On hybrid sdks we only care about the transaction running on its own layer (JS RN). |
For .NET we are addressing in getsentry/sentry-dotnet#1996 We needed to choose a transaction status for these failed transactions. Since the unhandled exception is interrupting the transaction, we went with |
@mattjohnsonpint awesome, can you amend the spec for this specific use case? |
@mattjohnsonpint have you had the chance to work on this? Apparently, .NET and JS diverge in status, .NET uses |
I haven't updated the spec yet. Thanks for the reminder. In TSC it was said that this behavior wasn't applicable for JS. I also mentioned status I'm not sure that it really matters much, as long as it's not status |
JS sets the status, but the transaction keeps running because the process (browser) never dies, that's why it's not applicable to JS, so
|
Add missing SDKs, See SDKs that support the Perf API https://docs.sentry.io/product/performance/getting-started/
The text was updated successfully, but these errors were encountered: