Fix bug with pre-formatted strings passed to diagnostic loggers #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjohnsonpint
commented
Oct 19, 2022
mattjohnsonpint
commented
Oct 19, 2022
SimonCropp
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue in the diagnostic loggers caused when .NET's
String.Formatis invoked on a pre-formatted string that contains characters that could be interpreted as formatting characters. For example,"{foo:bar}"passed as a message would raise aFormatException.This was most obvious on Android, when something logged from the native Android SDK that contained arguments was passed upstream to the .NET diagnostic logger. Accordingly, this PR fixes #2000.
Also with this PR:
SentryOptions.Debug == trueInternalsVisibleToto ensure we can use the Sentry Android/Cocoa bindings in our unit testsThe
AndroidDiagnosticLoggerTestsis also the first that is strictly platform-specific, running only with device tests. The infrastructure of which was created with #2002.