ref: Exclude electron from no-implicit-dependencies (#123)

src/main/backend.ts

@@ -1,11 +1,4 @@
-import {
-  app,
-  crashReporter,
-  ipcMain,
-  powerMonitor,
-  screen,
-  // tslint:disable-next-line:no-implicit-dependencies
-} from 'electron';
+import { app, crashReporter, ipcMain, powerMonitor, screen } from 'electron';
 import { join } from 'path';
 
 import { Breadcrumb, SentryEvent, SentryResponse, Severity, Status } from '@sentry/types';

src/main/context.ts

@@ -5,7 +5,6 @@ import { join } from 'path';
 import { promisify } from 'util';
 
 import { SentryEvent } from '@sentry/types';
-// tslint:disable-next-line:no-implicit-dependencies
 import { app } from 'electron';
 
 const execFile = promisify(child.execFile);

src/main/integrations/onuncaughtexception.ts

@@ -1,9 +1,6 @@
 import { getCurrentHub, NodeClient } from '@sentry/node';
 import { Integration, SentryEvent, Severity } from '@sentry/types';
-import {
-  dialog,
-  // tslint:disable-next-line:no-implicit-dependencies
-} from 'electron';
+import { dialog } from 'electron';
 
 /** Capture unhandled erros. */
 export class OnUncaughtException implements Integration {

src/main/normalize.ts

@@ -1,6 +1,5 @@
 import { SentryEvent, SentryException, Stacktrace } from '@sentry/types';
 import { clone } from '@sentry/utils/object';
-// tslint:disable-next-line:no-implicit-dependencies
 import { app } from 'electron';
 
 /** Application base path used for URL normalization. */

src/main/transports/net.ts

@@ -2,10 +2,7 @@ import { SentryError } from '@sentry/core';
 import { Transports } from '@sentry/node';
 import { SentryEvent, SentryResponse, Status, TransportOptions } from '@sentry/types';
 import { serialize } from '@sentry/utils/object';
-import {
-  net,
-  // tslint:disable-next-line:no-implicit-dependencies
-} from 'electron';
+import { net } from 'electron';
 import { isAppReady } from '../backend';
 
 /** Using net module of electron */

src/renderer/backend.ts

@@ -1,4 +1,3 @@
-// tslint:disable-next-line:no-implicit-dependencies
 import { crashReporter, ipcRenderer, remote } from 'electron';
 
 import { BrowserBackend } from '@sentry/browser';

src/renderer/client.ts

@@ -1,7 +1,6 @@
 import { BrowserClient, ReportDialogOptions } from '@sentry/browser';
 import { BaseClient, getCurrentHub, Scope } from '@sentry/core';
 import { Breadcrumb, SentryBreadcrumbHint, SentryEvent } from '@sentry/types';
-// tslint:disable-next-line:no-implicit-dependencies
 import { ipcRenderer } from 'electron';
 import { CommonClient, ElectronOptions, IPC_CRUMB } from '../common';
 import { RendererBackend } from './backend';

tslint.json

@@ -1,3 +1,7 @@
 {
-  "extends": "@sentry/typescript/tslint"
+  "extends": "@sentry/typescript/tslint",
+  "rules": {
+    // electron is not installed as a dependency
+    "no-implicit-dependencies": [true, ["electron"]]
+  }
 }