feat: enable attach stack traces and disable attach threads by default (

#921)
getsentry · Sep 15, 2020 · 14d1f43 · 14d1f43
1 parent 1f53b8d
commit 14d1f43
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/sentry/src/main/java/io/sentry/SentryOptions.java b/sentry/src/main/java/io/sentry/SentryOptions.java
@@ -156,13 +156,13 @@ public class SentryOptions {
   private @Nullable String dist;
 
   /** When enabled, threads are automatically attached to all logged events. */
-  private boolean attachThreads = true;
+  private boolean attachThreads;
 
   /**
    * When enabled, stack traces are automatically attached to all threads logged. Stack traces are
    * always attached to exceptions but when this is set stack traces are also sent with threads
    */
-  private boolean attachStacktrace;
+  private boolean attachStacktrace = true;
 
   /** Whether to enable or disable automatic session tracking. */
   private boolean enableSessionTracking = true;

diff --git a/sentry/src/test/java/io/sentry/SentryOptionsTest.kt b/sentry/src/test/java/io/sentry/SentryOptionsTest.kt
@@ -135,4 +135,14 @@ class SentryOptionsTest {
 
         assertEquals(clientName, sentryOptions.sentryClientName)
     }
+
+    @Test
+    fun `when options is initialized, attachThreads is false`() {
+        assertFalse(SentryOptions().isAttachThreads)
+    }
+
+    @Test
+    fun `when options is initialized, attachStacktrace is true`() {
+        assertTrue(SentryOptions().isAttachStacktrace)
+    }
 }