Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable attach stack traces and disable attach threads by default #921

Merged
merged 1 commit into from Sep 15, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Sep 15, 2020

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

feat: enable attach stack traces and disable attach threads by default

馃挕 Motivation and Context

threads are not useful if no stack traces, so threads are disabled by default, but if enabled, you get stack traces by default

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

馃敭 Next steps

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2020

Codecov Report

Merging #921 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #921   +/-   ##
=========================================
  Coverage     70.60%   70.60%           
+ Complexity     1207     1206    -1     
=========================================
  Files           122      122           
  Lines          4466     4466           
  Branches        454      454           
=========================================
  Hits           3153     3153           
  Misses         1066     1066           
  Partials        247      247           
Impacted Files Coverage 螖 Complexity 螖
sentry/src/main/java/io/sentry/SentryOptions.java 78.03% <100.00%> (酶) 75.00 <0.00> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b6e99c2...5d0a4e2. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome job 馃榿

@marandaneto marandaneto merged commit 14d1f43 into main Sep 15, 2020
@marandaneto marandaneto deleted the feat/enable-attach-stacktrace branch September 15, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants