Allow Sentry to recover from having been called before init

getsentry · Jun 2, 2022 · 2d41bbb · 2d41bbb
1 parent 77fd2f2
commit 2d41bbb
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/sentry/src/main/java/io/sentry/Sentry.java b/sentry/src/main/java/io/sentry/Sentry.java
@@ -41,7 +41,7 @@ private Sentry() {}
       return mainHub;
     }
     IHub hub = currentHub.get();
-    if (hub == null) {
+    if (hub == null || hub instanceof NoOpHub) {
       hub = mainHub.clone();
       currentHub.set(hub);
     }

diff --git a/sentry/src/test/java/io/sentry/SentryTest.kt b/sentry/src/test/java/io/sentry/SentryTest.kt
@@ -14,8 +14,8 @@ import kotlin.test.BeforeTest
 import kotlin.test.Test
 import kotlin.test.assertEquals
 import kotlin.test.assertFalse
+import kotlin.test.assertNotNull
 import kotlin.test.assertTrue
-
 class SentryTest {
 
     private val dsn = "http://key@localhost/proj"
@@ -209,6 +209,30 @@ class SentryTest {
         assertFalse(File(sentryOptions?.profilingTracesDirPath!!).exists())
     }
 
+    @Test
+    fun `using sentry before calling init creates NoOpHub but after init Sentry uses a new clone`() {
+        // noop as not yet initialized, caches NoOpHub in ThreadLocal
+        Sentry.captureMessage("noop caused")
+
+        assertTrue(Sentry.getCurrentHub() is NoOpHub)
+
+        // init Sentry in another thread
+        val thread = Thread() {
+            Sentry.init {
+                it.dsn = dsn
+                it.isDebug = true
+            }
+        }
+        thread.start()
+        thread.join()
+
+        Sentry.captureMessage("should work now")
+
+        val hub = Sentry.getCurrentHub()
+        assertNotNull(hub)
+        assertFalse(hub is NoOpHub)
+    }
+
     private fun getTempPath(): String {
         val tempFile = Files.createTempDirectory("cache").toFile()
         tempFile.delete()