Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align getSpan method from Scope on Android/Java and iOS #1828

Closed
marandaneto opened this issue Dec 6, 2021 · 2 comments
Closed

Align getSpan method from Scope on Android/Java and iOS #1828

marandaneto opened this issue Dec 6, 2021 · 2 comments
Assignees
Milestone

Comments

@marandaneto
Copy link
Contributor

marandaneto commented Dec 6, 2021

related to #1827 and #1822

Since they have different behavior on both platforms.
on iOS it always returns the root transaction.
on Android/Java it returns the latest active span.

@marandaneto marandaneto added performance Performance API issues Status: Backlog labels Dec 6, 2021
@marandaneto
Copy link
Contributor Author

marandaneto commented Dec 15, 2021

If hub is globalMode enabled, we always return the root transaction.

Doing this we don't need to do #1827

This is going to break the relationship for the DB auto instrumentation, We have to create the parent span, hold the reference and create the child from it, which requires changes on the Plugin.

This is not considered a breaking change.

Next:
We should talk about the thread-local storage before going forward.

@romtsn
Copy link
Member

romtsn commented Sep 6, 2023

Closed by #2855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

6 participants