Return transaction for Sentry.getSpan when global hub mode is enabled

[markushi]

📜 Description

Fixes #1828

💡 Motivation and Context

Just like Cocoa, always return the root transaction instead of the last active span. This is only applied if globalHubMode is enabled.

💚 How did you test it?

📝 Checklist

• I reviewed the submitted code.
• I added tests to verify the changes.
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
• I updated the docs if needed.
• Review from the native team if needed.
• No breaking change or entry added to the changelog.
• No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

[github-actions]

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against a1914e9

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	358.48 ms	361.78 ms	3.30 ms
Size	1.72 MiB	2.26 MiB	547.97 KiB

Previous results on branch: feat/get-span-root-span

Startup times

Revision	Plain	With Sentry	Diff
015f93f	314.22 ms	348.98 ms	34.75 ms
bfee4ed	342.45 ms	369.92 ms	27.47 ms
e9072f6	295.55 ms	371.12 ms	75.57 ms
3d502fb	316.02 ms	358.81 ms	42.79 ms
6cd0641	312.44 ms	359.16 ms	46.72 ms
9ef1fa6	324.19 ms	374.00 ms	49.81 ms
e068d53	307.73 ms	340.84 ms	33.11 ms

App size

Revision	Plain	With Sentry	Diff
015f93f	1.72 MiB	2.26 MiB	547.97 KiB
bfee4ed	1.72 MiB	2.29 MiB	575.30 KiB
e9072f6	1.72 MiB	2.29 MiB	575.26 KiB
3d502fb	1.72 MiB	2.29 MiB	576.58 KiB
6cd0641	1.72 MiB	2.26 MiB	547.97 KiB
9ef1fa6	1.72 MiB	2.29 MiB	576.28 KiB
e068d53	1.72 MiB	2.29 MiB	575.30 KiB

[codecov]

Codecov Report

Patch coverage is 87.53% of modified lines.

Files Changed	Coverage
...racing/SentrySpanClientHttpRequestInterceptor.java	0.00%
...ebflux/SentryWebFilterWithThreadLocalAccessor.java	0.00%
...racing/SentrySpanClientHttpRequestInterceptor.java	0.00%
sentry/src/main/java/io/sentry/Breadcrumb.java	ø
sentry/src/main/java/io/sentry/HostnameCache.java	ø
sentry/src/main/java/io/sentry/IHub.java	ø
.../src/main/java/io/sentry/JsonObjectSerializer.java	ø
sentry/src/main/java/io/sentry/NoOpHub.java	0.00%
...ry/src/main/java/io/sentry/ProfilingTraceData.java	ø
.../main/java/io/sentry/ProfilingTransactionData.java	ø
... and 89 more

📢 Thoughts on this report? Let us know!.

[romtsn]

I think simply changing this on the Sentry.java level is probably not enough, because we are using Hub.getSpan() in our own auto-instrumentation, and those will still be returning the latest span and not the root one.

Also, we've talked about introducing another method getLatestSpan or something like that, which we can use in our DB instrumentation to not break the parent-child relationship for Room+SQLite spans, can we also do that in this PR please?

[markushi]

I think simply changing this on the Sentry.java level is probably not enough, because we are using Hub.getSpan() in our own auto-instrumentation, and those will still be returning the latest span and not the root one.

As of now globalhub mode is not stored anywhere but Sentry.java so the hub itself doesn't know if it's global or not - let me look into this.

Also, we've talked about introducing another method getLatestSpan or something like that, which we can use in our DB instrumentation to not break the parent-child relationship for Room+SQLite spans, can we also do that in this PR please?

Yes, we thought about this, on it...

[romtsn]

As of now globalhub mode is not stored anywhere but Sentry.java so the hub itself doesn't know if it's global or not - let me look into this.

We could just use hub.getTransaction() in our integrations maybe, where applicable

[romtsn]

LGTM, but I think we also have to do it for Apollo, at least on Android? Is the apollo integration used server-side as well @adinauer? But we have the same problem for the okhttp integration now anyway, if someone is using it on the server alongside the Java SDK

[adinauer]

Is the apollo integration used server-side as well

It's a client only, we have support for graphql-java on server side which is used by Netflix DGS as well as spring-graphql.

Or do you mean can this be used in a backend application? That's a yes.

Not really sure about details here, maybe we can do a quick call if you need my input here so I can better grasp implications.

[markushi]

Let's change the Sentry.getSpan() behavior for Android only. In case this comes up for Desktop/Cli let's deal with this at a later point.

[romtsn]

@markushi I think the PR is still missing SentryApolloInterceptor and SentryApollo3Interceptor from the list 😅

[romtsn]

looks good now, thanks for addressing back-and-forths 🎉