Use Hub.getSpan instead of Sentry.getSpan #535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
markushi
commented
Jul 31, 2023
| ISpan child = null; | ||
| if (span != null) { | ||
| child = span.startChild("db", <description>); | ||
| } | ||
| */ | ||
| protected fun MethodVisitor.visitStartSpan( | ||
| attachToRoot: Boolean, |
There was a problem hiding this comment.
Not sure if we need this flag. But in theory we could always attach the room spans to the root and the sqlite spans to the last active span
There was a problem hiding this comment.
yeah, I think I'd just do that without the flag
romtsn
reviewed
Aug 2, 2023
.../src/main/kotlin/io/sentry/android/gradle/instrumentation/AbstractSpanAddingMethodVisitor.kt
Outdated
Show resolved
Hide resolved
markushi
changed the title
romtsn
approved these changes
Aug 9, 2023
|
Closing as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摐 Description
Switch from
Sentry.getSpan()toHubAdapter.getInstance().getTransaction() / getSpan()eventually.馃挕 Motivation and Context
getsentry/sentry-java#2855
getsentry/sentry-java#1828
馃挌 How did you test it?
馃摑 Checklist
馃敭 Next steps