Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich Transactions with Context Data #1469

Merged
merged 13 commits into from May 17, 2021
Merged

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented May 11, 2021

馃摐 Description

  • When OutboxSender picks up a file containing a transaction item, it will call captureTransaction instead of packing it up and calling 'captureEnvelope'.
  • We set the property contexts.trace.sampled to true manually as a workaround, as this is a transient property and not serialized. Without it, the transaction would be dropped.

馃挕 Motivation and Context

馃挌 How did you test it?

Bildschirmfoto 2021-05-14 um 16 20 20

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

@denrase denrase self-assigned this May 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021

Codecov Report

Merging #1469 (21eb8f8) into main (09389ff) will decrease coverage by 0.10%.
The diff coverage is 57.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1469      +/-   ##
============================================
- Coverage     75.86%   75.75%   -0.11%     
- Complexity     1922     1926       +4     
============================================
  Files           190      190              
  Lines          6555     6580      +25     
  Branches        659      665       +6     
============================================
+ Hits           4973     4985      +12     
- Misses         1263     1270       +7     
- Partials        319      325       +6     
Impacted Files Coverage 螖 Complexity 螖
sentry/src/main/java/io/sentry/OutboxSender.java 63.06% <57.50%> (-2.06%) 20.00 <3.00> (+4.00) 猬囷笍
...n/java/io/sentry/transport/ReusableCountLatch.java 88.23% <0.00%> (-5.89%) 8.00% <0.00%> (酶%)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 09389ff...21eb8f8. Read the comment docs.

@denrase denrase marked this pull request as ready for review May 14, 2021 14:25
@denrase denrase marked this pull request as draft May 14, 2021 15:38
@marandaneto
Copy link
Contributor

@denrase left a few suggestions but looks good to me.
add an entry to the changelog and mark as ready to review :)
I can release a new beta after that too, so we can bump the Android SDK for React Native SDK, so @jennmueng could run a few tests :)

@denrase denrase marked this pull request as ready for review May 17, 2021 10:07
@marandaneto marandaneto merged commit e587075 into main May 17, 2021
@marandaneto marandaneto deleted the feat/enriched-transactions branch May 17, 2021 11:50
@github-actions
Copy link
Contributor

Fails
馃毇 Please consider adding a changelog entry for the next release.
`Instructions and example for changelog`$

Please add an entry to CHANGELOG.md` to the "Unreleased" section under the following heading:

To the changelog entry, please add a link to this PR (consider a more descriptive message):`

- Enrich Transactions with Context Data(#1469)

If none of the above apply, you can opt out by adding _#skip-changelog_ to the PR description.

Generated by 馃毇 dangerJS against 21eb8f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get device context on Performance on Android
3 participants