Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get device context on Performance on Android #1291

Closed
bruno-garcia opened this issue Jan 18, 2021 · 4 comments · Fixed by getsentry/sentry-java#1469
Closed

Get device context on Performance on Android #1291

bruno-garcia opened this issue Jan 18, 2021 · 4 comments · Fixed by getsentry/sentry-java#1469
Labels
performance Platform: Android
Projects
Mobile Platform Team Archived

Comments

@bruno-garcia
Copy link
Member

This requires a change on Android to prepareEvent where an event is taken as an argument and is returned fully enriched.
@bruno-garcia bruno-garcia added this to Backlog in Mobile Platform Team Archived via automation Jan 18, 2021
@jennmueng jennmueng mentioned this issue Jan 25, 2021
Closed
14 tasks
@jennmueng jennmueng moved this from Backlog to Next in Mobile Platform Team Archived Jan 25, 2021
@bruno-garcia
Copy link
Member Author

Related to: getsentry/sentry-java#1234

@marandaneto
Copy link
Contributor

cc @denrase

@marandaneto marandaneto mentioned this issue May 18, 2021
Merged
4 tasks
@marandaneto
Copy link
Contributor

@jennmueng fix is merged, it'll be published in the next beta version of the Android SDK
we're still not offering the prepareEvent method because it'd require a big change so for now we enrich the transactions in the same way as events, it was an easy fix and it'd bring more value right away, so no changes on the RN SDK other than bumping the Android SDK

@marandaneto
Copy link
Contributor

https://github.com/getsentry/sentry-java/releases/tag/5.0.0-beta.4
cc @denrase

Mobile Platform Team Archived automation moved this from Next to Done May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Platform: Android
Projects
No open projects
Mobile Platform Team Archived
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enrich Transactions with Context Data getsentry/sentry-java
3 participants
@bruno-garcia @marandaneto @jennmueng