Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of event filtering mechanisms #2001

Merged
merged 6 commits into from May 3, 2022

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Apr 22, 2022

馃摐 Description

Event drop vs session update inconsistencies have been discussed in the Client Infra TSC. Python implementation has been updated to serve as reference implementation. We now only want to update the session when an event is dropped due to sampling but not if it is dropped due to any other filtering mechanism (beforeSend, eventProcessor, ignoredExceptionsForType). Also the order of the filtering mechanisms should be aligned across SDKs.

馃挕 Motivation and Context

Fixes: #1916

More Info:

馃挌 How did you test it?

馃摑 Checklist

馃敭 Next steps

  • Clarify some open questions regarding early return vs sending the session update alone

@adinauer adinauer changed the base branch from main to 6.x.x April 22, 2022 06:14
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2022

Codecov Report

Merging #2001 (a85eca4) into 6.x.x (4781d52) will decrease coverage by 0.01%.
The diff coverage is 90.00%.

@@             Coverage Diff              @@
##              6.x.x    #2001      +/-   ##
============================================
- Coverage     80.79%   80.77%   -0.02%     
  Complexity     3131     3131              
============================================
  Files           228      228              
  Lines         11619    11622       +3     
  Branches       1555     1556       +1     
============================================
+ Hits           9387     9388       +1     
  Misses         1648     1648              
- Partials        584      586       +2     
Impacted Files Coverage 螖
sentry/src/main/java/io/sentry/SentryClient.java 87.93% <90.00%> (-0.48%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 4781d52...a85eca4. Read the comment docs.

@adinauer adinauer changed the title Fix/event drop session update inconsistencies Fix/Change order of event filtering mechanisms Apr 26, 2022
@adinauer adinauer changed the title Fix/Change order of event filtering mechanisms Fix: Change order of event filtering mechanisms Apr 26, 2022
@adinauer adinauer changed the title Fix: Change order of event filtering mechanisms Change order of event filtering mechanisms May 3, 2022
@adinauer adinauer marked this pull request as ready for review May 3, 2022 07:18
@adinauer adinauer requested a review from romtsn as a code owner May 3, 2022 07:18
@adinauer adinauer merged commit 4fd621e into 6.x.x May 3, 2022
@adinauer adinauer deleted the fix/event-drop-session-update-inconsistencies branch May 3, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent event drop vs session update logic
4 participants