Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only send session update for dropped events if state changed #2002

Merged
merged 21 commits into from May 3, 2022

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Apr 22, 2022

📜 Description

Extra for #2001 to only send session update for dropped events if session state changed (healty -> errored or errored -> crashed).

💡 Motivation and Context

See linked PR for more context. This should ensure session updates make it to the server for dropped events that changed the session state.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

  • Add tests

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2022

Codecov Report

Merging #2002 (bba94ea) into fix/event-drop-session-update-inconsistencies (a85eca4) will increase coverage by 0.01%.
The diff coverage is 91.30%.

@@                                 Coverage Diff                                 @@
##             fix/event-drop-session-update-inconsistencies    #2002      +/-   ##
===================================================================================
+ Coverage                                            80.77%   80.79%   +0.01%     
- Complexity                                            3131     3146      +15     
===================================================================================
  Files                                                  228      228              
  Lines                                                11622    11642      +20     
  Branches                                              1556     1565       +9     
===================================================================================
+ Hits                                                  9388     9406      +18     
- Misses                                                1648     1649       +1     
- Partials                                               586      587       +1     
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/SentryClient.java 87.77% <91.30%> (-0.16%) ⬇️
sentry/src/main/java/io/sentry/ISentryClient.java 90.90% <0.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a85eca4...bba94ea. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adinauer adinauer changed the title Only send session update for dropped events if state changed Fix: Only send session update for dropped events if state changed Apr 26, 2022
adinauer and others added 4 commits April 26, 2022 15:29
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
… github.com:getsentry/sentry-java into fix/event-drop-session-update-inconsistencies-extra
@adinauer adinauer marked this pull request as ready for review May 3, 2022 06:50
@adinauer adinauer requested a review from romtsn as a code owner May 3, 2022 06:50
@adinauer adinauer changed the title Fix: Only send session update for dropped events if state changed Only send session update for dropped events if state changed May 3, 2022
... where the session update is not sent
because it does not change the health of the sesssion
Base automatically changed from fix/event-drop-session-update-inconsistencies to 6.x.x May 3, 2022 08:49
@adinauer adinauer merged commit e91f397 into 6.x.x May 3, 2022
@adinauer adinauer deleted the fix/event-drop-session-update-inconsistencies-extra branch May 3, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants