Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make user segment a top level property #2257

Merged
merged 5 commits into from Sep 27, 2022

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Sep 26, 2022

馃摐 Description

User segment is now a top level property.

馃挕 Motivation and Context

Closes #2240

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2022

Fails
馃毇 Please consider adding a changelog entry for the next release.
Messages
馃摉 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Make user segment a top level property ([#2257](https://github.com/getsentry/sentry-java/pull/2257))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 馃毇 dangerJS against e635106

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2022

Performance metrics 馃殌

Plain With Sentry Diff
Startup time 354.44 ms 362.06 ms 7.62 ms
Size 1.74 MiB 2.33 MiB 607.44 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3d89dea 345.59 ms 364.06 ms 18.47 ms
1e4690d 354.69 ms 387.88 ms 33.19 ms
3d89dea 322.38 ms 350.82 ms 28.45 ms
2f079a1 296.91 ms 337.43 ms 40.51 ms

App size

Revision Plain With Sentry Diff
3d89dea 1.74 MiB 2.33 MiB 604.92 KiB
1e4690d 1.74 MiB 2.33 MiB 604.92 KiB
3d89dea 1.74 MiB 2.33 MiB 604.92 KiB
2f079a1 1.74 MiB 2.33 MiB 605.56 KiB

Previous results on branch: feat/make-user-segment-top-level-property

Startup times

Revision Plain With Sentry Diff
889d1d9 322.02 ms 341.21 ms 19.19 ms
c7dc7e4 357.37 ms 402.27 ms 44.90 ms

App size

Revision Plain With Sentry Diff
889d1d9 1.74 MiB 2.33 MiB 605.65 KiB
c7dc7e4 1.74 MiB 2.33 MiB 605.55 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@marandaneto
Copy link
Contributor

The class Request also has a other field which is not part of the spec either https://develop.sentry.dev/sdk/event-payloads/request/
I believe Request#data should be used instead as well, I'd confirm with the ingest team before doing this change tho, maybe raise a new issue.

@adinauer
Copy link
Member Author

The class Request also has a other field which is not part of the spec either develop.sentry.dev/sdk/event-payloads/request
I believe Request#data should be used instead as well, I'd confirm with the ingest team before doing this change tho, maybe raise a new issue.

Created #2259 to track and do separately.

@adinauer adinauer enabled auto-merge (squash) September 27, 2022 11:34
@adinauer adinauer merged commit c5ccd8a into main Sep 27, 2022
@adinauer adinauer deleted the feat/make-user-segment-top-level-property branch September 27, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User segment should be a top level property on the user
3 participants