Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gradle 8.0 #2563

Merged
merged 26 commits into from
Apr 7, 2023
Merged

Update to Gradle 8.0 #2563

merged 26 commits into from
Apr 7, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Feb 23, 2023

#skip-changelog

Short summary:

  • Most of the root project's build.gradle.kts changes are to fix the implicit dependency between tasks problem (e.g. we're not publishing -debug artifacts, spotless kotlin should not run over the sentry-native submodule, etc. etc.)
  • Most of the dependency version updates is to support Kotlin 1.8.0, which Gradle 8 ships with
  • jacoco configuration changes are introduced by Gradle 8
  • Removed duplicated KotlinCompile tasks config for some backend modules
  • Replaced the spring boot BOM plugin with platform, as the BOM plugin wasn't compatible with Gradle 8, but platform is technically the same BOM but without the plugin, so that just works

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 320.58 ms 376.20 ms 55.62 ms
Size 1.73 MiB 2.27 MiB 551.70 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
33c80c7 318.88 ms 348.14 ms 29.26 ms
17ab223 427.65 ms 484.31 ms 56.65 ms
d81684e 235.73 ms 328.76 ms 93.03 ms
33c80c7 331.94 ms 370.54 ms 38.60 ms

App size

Revision Plain With Sentry Diff
33c80c7 1.73 MiB 2.26 MiB 551.46 KiB
17ab223 1.73 MiB 2.34 MiB 626.85 KiB
d81684e 1.73 MiB 2.26 MiB 547.78 KiB
33c80c7 1.73 MiB 2.26 MiB 551.46 KiB

Previous results on branch: chore/gradle-80

Startup times

Revision Plain With Sentry Diff
c3bc7fd 318.40 ms 374.24 ms 55.84 ms
771de95 302.02 ms 398.43 ms 96.41 ms
f332815 295.96 ms 372.26 ms 76.30 ms
3b85ec8 353.12 ms 398.18 ms 45.06 ms
e490ef8 326.06 ms 377.21 ms 51.15 ms
9ce3b59 430.66 ms 502.16 ms 71.50 ms
7652e9f 322.84 ms 378.71 ms 55.87 ms
d550107 353.21 ms 372.78 ms 19.57 ms

App size

Revision Plain With Sentry Diff
c3bc7fd 1.73 MiB 2.34 MiB 626.30 KiB
771de95 1.73 MiB 2.34 MiB 626.30 KiB
f332815 1.73 MiB 2.26 MiB 551.46 KiB
3b85ec8 1.73 MiB 2.34 MiB 626.68 KiB
e490ef8 1.73 MiB 2.34 MiB 626.30 KiB
9ce3b59 1.73 MiB 2.34 MiB 626.68 KiB
7652e9f 1.73 MiB 2.34 MiB 626.30 KiB
d550107 1.73 MiB 2.34 MiB 626.68 KiB

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (cfc50d3) 81.39% compared to head (b890cd3) 81.37%.

❗ Current head b890cd3 differs from pull request most recent head 0ec7039. Consider uploading reports for the commit 0ec7039 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2563      +/-   ##
============================================
- Coverage     81.39%   81.37%   -0.02%     
+ Complexity     4231     4217      -14     
============================================
  Files           337      337              
  Lines         15622    15601      -21     
  Branches       2041     2035       -6     
============================================
- Hits          12715    12695      -20     
+ Misses         2112     2111       -1     
  Partials        795      795              

see 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-gradle.sh/v8.0.1 branch 2 times, most recently from 3bb96f5 to 8a8a01a Compare February 27, 2023 04:27
@romtsn romtsn mentioned this pull request Feb 27, 2023
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-gradle.sh/v8.0.1 branch 2 times, most recently from 3ee774e to 259fe64 Compare February 27, 2023 12:33
@romtsn
Copy link
Member Author

romtsn commented Feb 27, 2023

The PR is blocked by spotless diffplug/spotless#1572 due to an implicit dependency between spotlessKotlinGradle and buildCMake tasks. I'm thinking of temporarily disabling the formatting .gradle.kts files for now - this should work the issue around. Or we can wait on spotless for a couple of more weeks to see if they'll fix the issue or provide a different workaround.

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-gradle.sh/v8.0.1 branch 2 times, most recently from b54cd9e to 2c7052b Compare March 2, 2023 10:18
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-gradle.sh/v8.0.1 branch from 2c7052b to d7da641 Compare March 2, 2023 13:07
@romtsn romtsn changed the base branch from deps/scripts/update-gradle.sh/v8.0.1 to main March 13, 2023 22:18
@romtsn romtsn marked this pull request as ready for review March 14, 2023 07:14
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adinauer adinauer marked this pull request as draft March 16, 2023 09:03
@adinauer
Copy link
Member

Converted to draft as this breaks samples in IDE with error message:

Toolchain from `executable` property does not match toolchain from `javaLauncher` property

It seems using a preview version of Android Studio it's possible to select the embedded JDK of the IDE to make it work. In Android Studio Electric Eel | 2022.1.1 Patch 2 however it doesn't work as the embedded JDK is too old.

There's this gradle/gradle#22845 and https://stackoverflow.com/questions/75715341/toolchain-from-executable-property-does-not-match-toolchain-from-javalauncher where people are experiencing the same / similar problem.

@romtsn romtsn marked this pull request as ready for review April 3, 2023 20:54
@romtsn
Copy link
Member Author

romtsn commented Apr 3, 2023

ok @adinauer I've made it work, check 4e24af9. Dunno if it breaks something, but I didn't notice anything wrong/weird, since it should only affect these specific IJ run configurations. But you better test it as well, thanks.

Here's the jetbrains issue btw https://youtrack.jetbrains.com/issue/IDEA-316081/Gradle-8-toolchain-error-Toolchain-from-executable-property-does-not-match-toolchain-from-javaLauncher-property-when-different

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working now. Great job.

CHANGELOG.md Outdated Show resolved Hide resolved
@romtsn romtsn enabled auto-merge (squash) April 7, 2023 09:48
@romtsn romtsn merged commit d23b4ea into main Apr 7, 2023
13 of 15 checks passed
@romtsn romtsn deleted the chore/gradle-80 branch April 7, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants