-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Gradle 8.0 #2563
Update to Gradle 8.0 #2563
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
33c80c7 | 318.88 ms | 348.14 ms | 29.26 ms |
17ab223 | 427.65 ms | 484.31 ms | 56.65 ms |
d81684e | 235.73 ms | 328.76 ms | 93.03 ms |
33c80c7 | 331.94 ms | 370.54 ms | 38.60 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
33c80c7 | 1.73 MiB | 2.26 MiB | 551.46 KiB |
17ab223 | 1.73 MiB | 2.34 MiB | 626.85 KiB |
d81684e | 1.73 MiB | 2.26 MiB | 547.78 KiB |
33c80c7 | 1.73 MiB | 2.26 MiB | 551.46 KiB |
Previous results on branch: chore/gradle-80
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c3bc7fd | 318.40 ms | 374.24 ms | 55.84 ms |
771de95 | 302.02 ms | 398.43 ms | 96.41 ms |
f332815 | 295.96 ms | 372.26 ms | 76.30 ms |
3b85ec8 | 353.12 ms | 398.18 ms | 45.06 ms |
e490ef8 | 326.06 ms | 377.21 ms | 51.15 ms |
9ce3b59 | 430.66 ms | 502.16 ms | 71.50 ms |
7652e9f | 322.84 ms | 378.71 ms | 55.87 ms |
d550107 | 353.21 ms | 372.78 ms | 19.57 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c3bc7fd | 1.73 MiB | 2.34 MiB | 626.30 KiB |
771de95 | 1.73 MiB | 2.34 MiB | 626.30 KiB |
f332815 | 1.73 MiB | 2.26 MiB | 551.46 KiB |
3b85ec8 | 1.73 MiB | 2.34 MiB | 626.68 KiB |
e490ef8 | 1.73 MiB | 2.34 MiB | 626.30 KiB |
9ce3b59 | 1.73 MiB | 2.34 MiB | 626.68 KiB |
7652e9f | 1.73 MiB | 2.34 MiB | 626.30 KiB |
d550107 | 1.73 MiB | 2.34 MiB | 626.68 KiB |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2563 +/- ##
============================================
- Coverage 81.39% 81.37% -0.02%
+ Complexity 4231 4217 -14
============================================
Files 337 337
Lines 15622 15601 -21
Branches 2041 2035 -6
============================================
- Hits 12715 12695 -20
+ Misses 2112 2111 -1
Partials 795 795 see 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
3bb96f5
to
8a8a01a
Compare
3ee774e
to
259fe64
Compare
The PR is blocked by spotless diffplug/spotless#1572 due to an implicit dependency between spotlessKotlinGradle and buildCMake tasks. I'm thinking of temporarily disabling the formatting |
b54cd9e
to
2c7052b
Compare
2c7052b
to
d7da641
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Converted to draft as this breaks samples in IDE with error message:
It seems using a preview version of Android Studio it's possible to select the embedded JDK of the IDE to make it work. In Android Studio Electric Eel | 2022.1.1 Patch 2 however it doesn't work as the embedded JDK is too old. There's this gradle/gradle#22845 and https://stackoverflow.com/questions/75715341/toolchain-from-executable-property-does-not-match-toolchain-from-javalauncher where people are experiencing the same / similar problem. |
ok @adinauer I've made it work, check 4e24af9. Dunno if it breaks something, but I didn't notice anything wrong/weird, since it should only affect these specific IJ run configurations. But you better test it as well, thanks. Here's the jetbrains issue btw https://youtrack.jetbrains.com/issue/IDEA-316081/Gradle-8-toolchain-error-Toolchain-from-executable-property-does-not-match-toolchain-from-javaLauncher-property-when-different |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working now. Great job.
#skip-changelog
Short summary:
build.gradle.kts
changes are to fix the implicit dependency between tasks problem (e.g. we're not publishing-debug
artifacts, spotless kotlin should not run over thesentry-native
submodule, etc. etc.)platform
, as the BOM plugin wasn't compatible with Gradle 8, butplatform
is technically the same BOM but without the plugin, so that just works