Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump AGP versions #2574

Merged
merged 25 commits into from
Apr 7, 2023
Merged

Bump AGP versions #2574

merged 25 commits into from
Apr 7, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Feb 27, 2023

No description provided.

@romtsn
Copy link
Member Author

romtsn commented Feb 27, 2023

blocked by #2563

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 322.98 ms 376.00 ms 53.02 ms
Size 1.73 MiB 2.26 MiB 550.24 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
33c80c7 318.88 ms 348.14 ms 29.26 ms
17ab223 427.65 ms 484.31 ms 56.65 ms
d81684e 235.73 ms 328.76 ms 93.03 ms
33c80c7 331.94 ms 370.54 ms 38.60 ms

App size

Revision Plain With Sentry Diff
33c80c7 1.73 MiB 2.26 MiB 551.46 KiB
17ab223 1.73 MiB 2.34 MiB 626.85 KiB
d81684e 1.73 MiB 2.26 MiB 547.78 KiB
33c80c7 1.73 MiB 2.26 MiB 551.46 KiB

Previous results on branch: chore/rz/bump-agp

Startup times

Revision Plain With Sentry Diff
82bb061 305.94 ms 322.64 ms 16.70 ms

App size

Revision Plain With Sentry Diff
82bb061 1.73 MiB 2.26 MiB 550.25 KiB

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d23b4ea) 81.39% compared to head (094ea5c) 81.39%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2574   +/-   ##
=========================================
  Coverage     81.39%   81.39%           
  Complexity     4227     4227           
=========================================
  Files           337      337           
  Lines         15622    15622           
  Branches       2039     2039           
=========================================
  Hits          12715    12715           
  Misses         2112     2112           
  Partials        795      795           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romtsn romtsn changed the base branch from main to chore/gradle-80 March 16, 2023 08:57
Base automatically changed from chore/gradle-80 to main April 7, 2023 09:55
@romtsn romtsn marked this pull request as ready for review April 7, 2023 11:07
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@romtsn romtsn merged commit 18efe20 into main Apr 7, 2023
17 of 18 checks passed
@romtsn romtsn deleted the chore/rz/bump-agp branch April 7, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants