Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raven-android submodule. #261

Merged
merged 1 commit into from Oct 14, 2016
Merged

Add raven-android submodule. #261

merged 1 commit into from Oct 14, 2016

Conversation

bretthoerner
Copy link

@bretthoerner bretthoerner commented Oct 7, 2016

I confused Github somehow. This is a clean diff moved from #231


Probably belongs in raven-java:

  • Add simple static interface for sending exceptions, setting breadcrumbs. (e.g. Raven.sendException(e) so they don't have to pass a client around everywhere)

Mandatory for Android "hello world" (this PR):

  • Figure out a naming scheme for classes, they're wordy and/or confusing right now.
  • Enforce async for all communication. (networking on Main thread is an exception in Android) https://developer.android.com/reference/android/os/AsyncTask.html
  • Check internet connectivity permissions and complain in development mode.
  • Take DSN from manifest, or constructor, else throw exception.
  • Store exceptions when offline, send later.
  • Add ability to set release, or take automatically from app version if possible.

Follow-on issues to create:

@bretthoerner
Copy link
Author

Ugh, there are some comments here: #231 (review)

Github. :(

Copy link

@tkaemming tkaemming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I obviously don't have much experience with Android, so depending on your experience and research with their APIs. Everything that isn't Android specific looks good to me, though.

Log.d(TAG, "Uncaught exception received.");

try {
com.getsentry.raven.Raven.capture(thrown);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't this use com.getsentry.raven.android.Raven at this point?

@bretthoerner bretthoerner merged commit feed36b into master Oct 14, 2016
@bretthoerner bretthoerner deleted the raven-android-start2 branch October 14, 2016 18:18
@AndreasBackx
Copy link

Any update on the Proguard handling? We'd love to finally switch over all of our error logging to Sentry, but currently Android is still using Crashlytics because of the proguard support. Sentry isn't really viable without Proguard support for Android. There was an issue on this last year in the sentry repo, any update about that too perhaps?

@bretthoerner
Copy link
Author

Hey @AndreasBackx, Proguard support is super high priority for us. Soon!

@AndreasBackx
Copy link

@bretthoerner I myself would love to help out (even though I'm pretty tight on time). How far is development regarding proguard right now and how can I/we help? It shouldn't be a problem for me dive in either the core of sentry or raven-java. Could you sum up what needs to be done or what still needs to be done in greater detail?

@bretthoerner
Copy link
Author

@AndreasBackx I responded to you on a new ticket: #317

@AndreasBackx
Copy link

@bretthoerner might be a good idea to add it to the original PR's checkbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants