New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add raven-android submodule. #261
Conversation
Ugh, there are some comments here: #231 (review) Github. :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I obviously don't have much experience with Android, so depending on your experience and research with their APIs. Everything that isn't Android specific looks good to me, though.
Log.d(TAG, "Uncaught exception received."); | ||
|
||
try { | ||
com.getsentry.raven.Raven.capture(thrown); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't this use com.getsentry.raven.android.Raven
at this point?
Any update on the Proguard handling? We'd love to finally switch over all of our error logging to Sentry, but currently Android is still using Crashlytics because of the proguard support. Sentry isn't really viable without Proguard support for Android. There was an issue on this last year in the sentry repo, any update about that too perhaps? |
Hey @AndreasBackx, Proguard support is super high priority for us. Soon! |
@bretthoerner I myself would love to help out (even though I'm pretty tight on time). How far is development regarding proguard right now and how can I/we help? It shouldn't be a problem for me dive in either the core of sentry or raven-java. Could you sum up what needs to be done or what still needs to be done in greater detail? |
@AndreasBackx I responded to you on a new ticket: #317 |
@bretthoerner might be a good idea to add it to the original PR's checkbox. |
I confused Github somehow. This is a clean diff moved from #231
Probably belongs in
raven-java
:Raven.sendException(e)
so they don't have to pass a client around everywhere)Mandatory for Android "hello world" (this PR):
Follow-on issues to create:
contexts
in json probably? Initial pass on context data sentry#3521)