-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial pass on context data #3521
Conversation
IMO we should break up the context file. This has gotten to be a pattern lately and it's making some of the modules unwieldy. I dont know how deep we'll go into custom rendering for various styles of context, but as soon as these become more than "here are the field names" it really sucks to have to dig into a giant file to make changes. tl;dr I'm a big proponent of "one class per file" in most situations |
@@ -711,6 +712,7 @@ def create_partitioned_queues(name): | |||
'sentry.interfaces.Csp': 'sentry.interfaces.csp.Csp', | |||
'sentry.interfaces.AppleCrashReport': 'sentry.interfaces.applecrash.AppleCrashReport', | |||
'sentry.interfaces.Breadcrumbs': 'sentry.interfaces.breadcrumbs.Breadcrumbs', | |||
'sentry.interfaces.Contexts': 'sentry.interfaces.contexts.Contexts', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't add the full path
02e47ab
to
3ae8806
Compare
def to_json(self): | ||
return self.data | ||
|
||
def flatten_index_value(self, value): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats this mean? might be worthwhile to add some docstrings on the base type to explain input/output
4ea483e
to
b1f7310
Compare
b1f7310
to
f39aff9
Compare
We're still going to tweak the UI, but leaving a few notes on that here:
|
Some notes:
Experiences:
In the future it's possible we'll make these configurable, or we'll just do it based on what's available. |
1e2f581
to
cd52f8b
Compare
45f633b
to
aa50d23
Compare
Here's where we're at today: https://www.dropbox.com/s/jqaw2jkrmrvp4g7/Screenshot%202016-06-27%2010.36.00.png?dl=0 |
/cc @bretthoerner since this will be relevant for Android |
af7f052
to
c3aec12
Compare
Refs #3510
[1] context schemas
[2] context summary
[3] expanded contexts
@getsentry/infrastructure @getsentry/cocoa @getsentry/ui