Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lock attribute to the frame protocol #2761

Merged
merged 4 commits into from
Jun 2, 2023
Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jun 1, 2023

📜 Description

This is necessary in addition to SentryThread.held_locks to highlight the offending frame in the UI, so the lock has to be also on the per-frame level.

Relay PR: getsentry/relay#2171

💡 Motivation and Context

Q2 Goal

💚 How did you test it?

Manually and automated

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 291.57 ms 331.89 ms 40.32 ms
Size 1.72 MiB 2.28 MiB 571.59 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
16cd2b6 243.02 ms 349.69 ms 106.67 ms
46b1782 387.72 ms 458.74 ms 71.02 ms
1707044 338.80 ms 384.79 ms 46.00 ms

App size

Revision Plain With Sentry Diff
16cd2b6 1.72 MiB 2.28 MiB 570.95 KiB
46b1782 1.72 MiB 2.28 MiB 570.44 KiB
1707044 1.72 MiB 2.28 MiB 570.44 KiB

Previous results on branch: rz/feat/anr-v2-lock-per-frame

Startup times

Revision Plain With Sentry Diff
7830f11 322.64 ms 370.34 ms 47.70 ms

App size

Revision Plain With Sentry Diff
7830f11 1.72 MiB 2.28 MiB 571.59 KiB

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 85.71% and no project coverage change.

Comparison is base (baa4b26) 81.09% compared to head (89238ad) 81.10%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2761   +/-   ##
=========================================
  Coverage     81.09%   81.10%           
- Complexity     4470     4472    +2     
=========================================
  Files           347      347           
  Lines         16475    16482    +7     
  Branches       2232     2233    +1     
=========================================
+ Hits          13361    13367    +6     
- Misses         2181     2182    +1     
  Partials        933      933           
Impacted Files Coverage Δ
...main/java/io/sentry/protocol/SentryStackFrame.java 84.27% <85.71%> (+0.06%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@romtsn romtsn merged commit 4966d7f into main Jun 2, 2023
21 checks passed
@romtsn romtsn deleted the rz/feat/anr-v2-lock-per-frame branch June 2, 2023 06:47
@kahest kahest mentioned this pull request Jun 2, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants