Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow removing integrations in SentryAndroid.init #2826

Merged
merged 5 commits into from
Jul 11, 2023

Conversation

stefanosiano
Copy link
Member

@stefanosiano stefanosiano commented Jul 7, 2023

📜 Description

configure options now happens after adding integrations in SentryAndroid.init
added LazyEvaluator to evaluate a function lazily
AndroidOptionsInitializer.installDefaultIntegrations now evaluate cache dir lazily

💡 Motivation and Context

Fixes #2821 and #2355

💚 How did you test it?

Unit test

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 285.33 ms 324.30 ms 38.97 ms
Size 1.72 MiB 2.29 MiB 575.24 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8820c5c 330.60 ms 416.86 ms 86.26 ms
9246ed4 281.79 ms 352.08 ms 70.29 ms
496bdfd 301.22 ms 343.96 ms 42.73 ms
f274c79 334.86 ms 348.54 ms 13.68 ms
9246ed4 275.63 ms 321.31 ms 45.69 ms
f274c79 313.96 ms 355.96 ms 42.00 ms
c03a05e 390.40 ms 419.35 ms 28.94 ms
0310da5 381.20 ms 404.50 ms 23.30 ms
496bdfd 272.86 ms 407.33 ms 134.48 ms
dc67004 273.86 ms 346.37 ms 72.51 ms

App size

Revision Plain With Sentry Diff
8820c5c 1.72 MiB 2.28 MiB 571.82 KiB
9246ed4 1.72 MiB 2.28 MiB 572.22 KiB
496bdfd 1.72 MiB 2.28 MiB 571.82 KiB
f274c79 1.72 MiB 2.29 MiB 575.01 KiB
9246ed4 1.72 MiB 2.28 MiB 572.22 KiB
f274c79 1.72 MiB 2.29 MiB 575.01 KiB
c03a05e 1.72 MiB 2.29 MiB 574.43 KiB
0310da5 1.72 MiB 2.28 MiB 573.45 KiB
496bdfd 1.72 MiB 2.28 MiB 571.82 KiB
dc67004 1.72 MiB 2.28 MiB 573.45 KiB

Previous results on branch: fix/configure-options-after-adding-integrations

Startup times

Revision Plain With Sentry Diff
dbcee0c 311.49 ms 375.04 ms 63.55 ms
7637dd2 307.29 ms 375.62 ms 68.33 ms
633a727 287.35 ms 348.92 ms 61.57 ms

App size

Revision Plain With Sentry Diff
dbcee0c 1.72 MiB 2.29 MiB 574.96 KiB
7637dd2 1.72 MiB 2.29 MiB 575.06 KiB
633a727 1.72 MiB 2.29 MiB 574.96 KiB

@stefanosiano stefanosiano marked this pull request as ready for review July 7, 2023 16:13
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f274c79) 81.28% compared to head (3f5a679) 81.28%.

❗ Current head 3f5a679 differs from pull request most recent head 32134b8. Consider uploading reports for the commit 32134b8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2826   +/-   ##
=========================================
  Coverage     81.28%   81.28%           
  Complexity     4562     4562           
=========================================
  Files           350      350           
  Lines         16867    16867           
  Branches       2272     2272           
=========================================
  Hits          13710    13710           
  Misses         2216     2216           
  Partials        941      941           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good 🚀

AndroidOptionsInitializer.installDefaultIntegrations now evaluate cache dir lazily
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nicely done!

@stefanosiano stefanosiano merged commit 2186444 into main Jul 11, 2023
19 checks passed
@stefanosiano stefanosiano deleted the fix/configure-options-after-adding-integrations branch July 11, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to remove TempSensorBreadcrumbsIntegration (in new versions), causing app *rejected* by app stores
3 participants