-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow removing integrations in SentryAndroid.init #2826
Allow removing integrations in SentryAndroid.init #2826
Conversation
…ng-integrations' into fix/configure-options-after-adding-integrations
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8820c5c | 330.60 ms | 416.86 ms | 86.26 ms |
9246ed4 | 281.79 ms | 352.08 ms | 70.29 ms |
496bdfd | 301.22 ms | 343.96 ms | 42.73 ms |
f274c79 | 334.86 ms | 348.54 ms | 13.68 ms |
9246ed4 | 275.63 ms | 321.31 ms | 45.69 ms |
f274c79 | 313.96 ms | 355.96 ms | 42.00 ms |
c03a05e | 390.40 ms | 419.35 ms | 28.94 ms |
0310da5 | 381.20 ms | 404.50 ms | 23.30 ms |
496bdfd | 272.86 ms | 407.33 ms | 134.48 ms |
dc67004 | 273.86 ms | 346.37 ms | 72.51 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8820c5c | 1.72 MiB | 2.28 MiB | 571.82 KiB |
9246ed4 | 1.72 MiB | 2.28 MiB | 572.22 KiB |
496bdfd | 1.72 MiB | 2.28 MiB | 571.82 KiB |
f274c79 | 1.72 MiB | 2.29 MiB | 575.01 KiB |
9246ed4 | 1.72 MiB | 2.28 MiB | 572.22 KiB |
f274c79 | 1.72 MiB | 2.29 MiB | 575.01 KiB |
c03a05e | 1.72 MiB | 2.29 MiB | 574.43 KiB |
0310da5 | 1.72 MiB | 2.28 MiB | 573.45 KiB |
496bdfd | 1.72 MiB | 2.28 MiB | 571.82 KiB |
dc67004 | 1.72 MiB | 2.28 MiB | 573.45 KiB |
Previous results on branch: fix/configure-options-after-adding-integrations
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
dbcee0c | 311.49 ms | 375.04 ms | 63.55 ms |
7637dd2 | 307.29 ms | 375.62 ms | 68.33 ms |
633a727 | 287.35 ms | 348.92 ms | 61.57 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
dbcee0c | 1.72 MiB | 2.29 MiB | 574.96 KiB |
7637dd2 | 1.72 MiB | 2.29 MiB | 575.06 KiB |
633a727 | 1.72 MiB | 2.29 MiB | 574.96 KiB |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2826 +/- ##
=========================================
Coverage 81.28% 81.28%
Complexity 4562 4562
=========================================
Files 350 350
Lines 16867 16867
Branches 2272 2272
=========================================
Hits 13710 13710
Misses 2216 2216
Partials 941 941 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good 🚀
sentry-android-core/src/main/java/io/sentry/android/core/SentryAndroid.java
Show resolved
Hide resolved
AndroidOptionsInitializer.installDefaultIntegrations now evaluate cache dir lazily
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nicely done!
📜 Description
configure options now happens after adding integrations in
SentryAndroid.init
added LazyEvaluator to evaluate a function lazily
AndroidOptionsInitializer.installDefaultIntegrations now evaluate cache dir lazily
💡 Motivation and Context
Fixes #2821 and #2355
💚 How did you test it?
Unit test
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps