-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: Add tests to demonstrate wrong scope data loss
- Loading branch information
Showing
4 changed files
with
91 additions
and
0 deletions.
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
dev-packages/browser-integration-tests/suites/public-api/withScope/throwError/subject.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
Sentry.setTag('global', 'tag'); | ||
setTimeout(() => { | ||
Sentry.withScope(scope => { | ||
scope.setTag('local', 'tag'); | ||
throw new Error('test error'); | ||
}); | ||
}, 10); |
16 changes: 16 additions & 0 deletions
16
dev-packages/browser-integration-tests/suites/public-api/withScope/throwError/test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import { expect } from '@playwright/test'; | ||
import type { Event } from '@sentry/types'; | ||
|
||
import { sentryTest } from '../../../../utils/fixtures'; | ||
import { getFirstSentryEnvelopeRequest } from '../../../../utils/helpers'; | ||
|
||
sentryTest('scope is applied to thrown error', async ({ getLocalTestPath, page }) => { | ||
const url = await getLocalTestPath({ testDir: __dirname }); | ||
|
||
const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url); | ||
|
||
const ex = eventData.exception?.values ? eventData.exception.values[0] : undefined; | ||
|
||
expect(eventData.tags).toMatchObject({ global: 'tag', local: 'tag' }); | ||
expect(ex?.value).toBe('test error'); | ||
}); |
26 changes: 26 additions & 0 deletions
26
dev-packages/node-integration-tests/suites/express/handle-error-withScope/server.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests'; | ||
import * as Sentry from '@sentry/node-experimental'; | ||
import express from 'express'; | ||
|
||
const app = express(); | ||
|
||
Sentry.init({ | ||
dsn: 'https://public@dsn.ingest.sentry.io/1337', | ||
release: '1.0', | ||
transport: loggingTransport, | ||
}); | ||
|
||
app.use(Sentry.Handlers.requestHandler()); | ||
|
||
Sentry.setTag('global', 'tag'); | ||
|
||
app.get('/test/express', () => { | ||
Sentry.withScope(scope => { | ||
scope.setTag('local', 'tag'); | ||
throw new Error('test_error'); | ||
}) | ||
}); | ||
|
||
app.use(Sentry.Handlers.errorHandler()); | ||
|
||
startExpressServerAndSendPortToRunner(app); |
42 changes: 42 additions & 0 deletions
42
dev-packages/node-integration-tests/suites/express/handle-error-withScope/test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
import { cleanupChildProcesses, createRunner } from '../../../utils/runner'; | ||
|
||
afterAll(() => { | ||
cleanupChildProcesses(); | ||
}); | ||
|
||
test('applies withScope scope to thrown error', done => { | ||
const runner = createRunner(__dirname, 'server.ts') | ||
.ignore('session', 'sessions') | ||
.expect({ | ||
event: { | ||
exception: { | ||
values: [ | ||
{ | ||
mechanism: { | ||
type: 'middleware', | ||
handled: false, | ||
}, | ||
type: 'Error', | ||
value: 'test_error', | ||
stacktrace: { | ||
frames: expect.arrayContaining([ | ||
expect.objectContaining({ | ||
function: expect.any(String), | ||
lineno: expect.any(Number), | ||
colno: expect.any(Number), | ||
}), | ||
]), | ||
}, | ||
}, | ||
], | ||
}, | ||
tags: { | ||
'global': 'tag', | ||
'local': 'tag', // This tag is missing :( | ||
} | ||
}, | ||
}) | ||
.start(done); | ||
|
||
expect(() => runner.makeRequest('get', '/test/express')).rejects.toThrow(); | ||
}); |