Skip to content

Commit

Permalink
feat(metrics): Add secure connect navigation timing (#2980)
Browse files Browse the repository at this point in the history
* feat(metrics): Add secure connect navigation timing

This is helpful to determine whether the span needed to do tls negotation, and if so, how long it takes. Had to modify the addPerformanceNavigationTiming function to allow a custom end since secure connect's end is connectEnd.

* Update packages/tracing/src/browser/metrics.ts

Co-authored-by: Alberto Leal <mail4alberto@gmail.com>

Co-authored-by: Alberto Leal <mail4alberto@gmail.com>
  • Loading branch information
k-fish and dashed committed Oct 20, 2020
1 parent 0a305f6 commit 3a7be5b
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion packages/tracing/src/browser/metrics.ts
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,7 @@ function addNavigationSpans(transaction: Transaction, entry: Record<string, any>
addPerformanceNavigationTiming(transaction, entry, 'domContentLoadedEvent', timeOrigin);
addPerformanceNavigationTiming(transaction, entry, 'loadEvent', timeOrigin);
addPerformanceNavigationTiming(transaction, entry, 'connect', timeOrigin);
addPerformanceNavigationTiming(transaction, entry, 'secureConnection', timeOrigin, 'connectEnd');
addPerformanceNavigationTiming(transaction, entry, 'domainLookup', timeOrigin);
addRequest(transaction, entry, timeOrigin);
}
Expand Down Expand Up @@ -330,8 +331,9 @@ function addPerformanceNavigationTiming(
entry: Record<string, any>,
event: string,
timeOrigin: number,
eventEnd?: string,
): void {
const end = entry[`${event}End`] as number | undefined;
const end = eventEnd ? (entry[eventEnd] as number | undefined) : (entry[`${event}End`] as number | undefined);
const start = entry[`${event}Start`] as number | undefined;
if (!start || !end) {
return;
Expand Down

0 comments on commit 3a7be5b

Please sign in to comment.