feat(metrics): Add secure connect navigation timing #2980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is helpful to determine whether the span needed to do tls negotation, and if so, how long it takes. Had to modify the addPerformanceNavigationTiming function to allow a custom end since secure connect's end is connectEnd.
dashed
reviewed
Oct 17, 2020
Co-authored-by: Alberto Leal <mail4alberto@gmail.com>
size-limit report
|
dashed
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is helpful to determine whether the span needed to do tls negotation, and if so, how long it takes. Had to modify the
addPerformanceNavigationTimingfunction to allow a custom end since secure connect's end isconnectEnd.