feat: enable biome recommended linter rules

.eslintrc.js

@@ -28,6 +28,10 @@ module.exports = {
       rules: {
         // Disabled because it's included with Biome's linter
         'no-control-regex': 'off',
+        'no-param-reassign': 'off',
+        'prefer-const': 'off',
+        '@typescript-eslint/ban-types': 'off',
+        'react-hooks/exhaustive-deps': 'off',
       },
     },
     {

.size-limit.js

@@ -20,7 +20,7 @@ module.exports = [
     import: '{ init, Replay, BrowserTracing }',
     gzip: true,
     limit: '75 KB',
-    modifyWebpackConfig: function (config) {
+    modifyWebpackConfig: config => {
       const webpack = require('webpack');
       config.plugins.push(
         new webpack.DefinePlugin({

biome.json

@@ -11,18 +11,60 @@
   "linter": {
     "enabled": true,
     "rules": {
-      "recommended": false,
+      "recommended": true,
+      "a11y": {
+        "all": false
+      },
+      "complexity": {
+        "noForEach": "off",
+        "noUselessConstructor": "off",
+        "noStaticOnlyClass": "off",
+        "useOptionalChain": "off",
+        "useLiteralKeys": "off"
+      },
       "correctness": {
-        "all": false,
-        "noUnusedVariables": "error",
-        "noPrecisionLoss": "error"
+        "noEmptyPattern": "off",
+        "noInnerDeclarations": "off",
+        "noVoidTypeReturn": "off",
+        "noEmptyCharacterClassInRegex": "off"
+      },
+      "performance": {
+        "noDelete": "off"
+      },
+      "security": {
+        "all": true
+      },
+      "style": {
+        "noArguments": "off",
+        "noCommaOperator": "off",
+        "noNonNullAssertion": "off",
+        "noUselessElse": "off",
+        "useTemplate": "off",
+        "noVar": "off",
+        "useSingleVarDeclarator": "off",
+        "useDefaultParameterLast": "off",
+        "useExponentiationOperator": "off"
       },
       "suspicious": {
-        "all": false,
-        "noControlCharactersInRegex": "error"
+        "noDebugger": "off",
+        "noDoubleEquals": "off",
+        "noExplicitAny": "off",
+        "noRedeclare": "off",
+        "noAssignInExpressions": "off",
+        "noConfusingVoidType": "off",
+        "noPrototypeBuiltins": "off",
+        "noShadowRestrictedNames": "off",
+        "noControlCharactersInRegex": "off"
       }
     },
-    "ignore": [".vscode/*", "**/*.json"]
+    "ignore": [
+      ".vscode/*",
+      "**/*.json",
+      "**/*.min.js",
+      "packages/browser-integration-tests/fixtures/loader.js",
+      "packages/browser/test/integration/polyfills/*.js",
+      "packages/replay-worker/examples/worker.js"
+    ]
   },
   "files": {
     "ignoreUnknown": true
@@ -44,6 +86,7 @@
     ]
   },
   "javascript": {
+    "globals": ["expect", "describe", "test", "it", "beforeEach", "afterEach", "beforeAll", "afterAll"],
     "formatter": {
       "enabled": true,
       "quoteStyle": "single",

package.json

@@ -20,7 +20,7 @@
     "codecov": "codecov",
     "fix": "run-s fix:lerna fix:biome",
     "fix:lerna": "lerna run fix",
-    "fix:biome": "biome check --apply-unsafe .",
+    "fix:biome": "biome check --apply .",
     "changelog": "ts-node ./scripts/get-commit-list.ts",
     "link:yarn": "lerna exec yarn link",
     "lint": "run-s lint:lerna lint:biome",

packages/angular/src/tracing.ts

@@ -27,8 +27,8 @@ let stashedStartTransactionOnLocationChange: boolean;
  */
 export function routingInstrumentation(
   customStartTransaction: (context: TransactionContext) => Transaction | undefined,
-  startTransactionOnPageLoad: boolean = true,
-  startTransactionOnLocationChange: boolean = true,
+  startTransactionOnPageLoad = true,
+  startTransactionOnLocationChange = true,
 ): void {
   instrumentationInitialized = true;
   stashedStartTransaction = customStartTransaction;
@@ -260,7 +260,8 @@ export function TraceClassDecorator(): ClassDecorator {
  * Decorator function that can be used to capture a single lifecycle methods of the component.
  */
 export function TraceMethodDecorator(): MethodDecorator {
-  // eslint-disable-next-line @typescript-eslint/explicit-function-return-type, @typescript-eslint/ban-types
+  // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
+  // biome-ignore lint/complexity/noBannedTypes: Disable
   return (target: Object, propertyKey: string | symbol, descriptor: PropertyDescriptor) => {
     const originalMethod = descriptor.value;
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -300,7 +301,7 @@ export function getParameterizedRouteFromSnapshot(route?: ActivatedRouteSnapshot
   let currentRoute = route && route.firstChild;
   while (currentRoute) {
     const path = currentRoute && currentRoute.routeConfig && currentRoute.routeConfig.path;
-    if (path === null || path === undefined) {
+    if (path == null) {
       break;
     }
 

packages/browser-integration-tests/loader-suites/loader/noOnLoad/unhandeledPromiseRejectionHandler/subject.js

@@ -1,3 +1,3 @@
-new Promise(function (resolve, reject) {
+new Promise((resolve, reject) => {
   reject('this is unhandled');
 });

packages/browser-integration-tests/loader-suites/loader/onLoad/captureExceptionInOnLoad/init.js

@@ -1,4 +1,4 @@
-Sentry.onLoad(function () {
+Sentry.onLoad(() => {
   // You _have_ to call Sentry.init() before calling Sentry.captureException() in Sentry.onLoad()!
   Sentry.init();
   Sentry.captureException('Test exception');

packages/browser-integration-tests/loader-suites/loader/onLoad/customBrowserTracing/init.js

@@ -1,6 +1,6 @@
 window._testBaseTimestamp = performance.timeOrigin / 1000;
 
-Sentry.onLoad(function () {
+Sentry.onLoad(() => {
   Sentry.init({
     integrations: [
       // Without this syntax, this will be re-written by the test framework

packages/browser-integration-tests/loader-suites/loader/onLoad/customInit/init.js

@@ -1,7 +1,7 @@
 window.__sentryOnLoad = 0;
 
 setTimeout(() => {
-  Sentry.onLoad(function () {
+  Sentry.onLoad(() => {
     window.__hadSentry = window.sentryIsLoaded();
 
     Sentry.init({

packages/browser-integration-tests/loader-suites/loader/onLoad/customIntegrations/init.js

@@ -6,7 +6,7 @@ class CustomIntegration {
   setupOnce() {}
 }
 
-Sentry.onLoad(function () {
+Sentry.onLoad(() => {
   Sentry.init({
     integrations: [new CustomIntegration()],
   });

packages/browser-integration-tests/loader-suites/loader/onLoad/customIntegrationsFunction/init.js

@@ -6,7 +6,7 @@ class CustomIntegration {
   setupOnce() {}
 }
 
-Sentry.onLoad(function () {
+Sentry.onLoad(() => {
   Sentry.init({
     integrations: integrations => [new CustomIntegration()].concat(integrations),
   });

packages/browser-integration-tests/loader-suites/loader/onLoad/customReplay/init.js

@@ -1,4 +1,4 @@
-Sentry.onLoad(function () {
+Sentry.onLoad(() => {
   Sentry.init({
     integrations: [
       // Without this syntax, this will be re-written by the test framework

packages/browser-integration-tests/loader-suites/loader/onLoad/init.js

@@ -1,3 +1,3 @@
-Sentry.onLoad(function () {
+Sentry.onLoad(() => {
   Sentry.init({});
 });

packages/browser-integration-tests/loader-suites/loader/onLoad/onLoadLate/subject.js

@@ -1,7 +1,7 @@
 Sentry.forceLoad();
 
 setTimeout(() => {
-  Sentry.onLoad(function () {
+  Sentry.onLoad(() => {
     Sentry.captureException('Test exception');
   });
 }, 200);

packages/browser-integration-tests/loader-suites/loader/onLoad/pageloadTransaction/init.js

@@ -1,5 +1,5 @@
 window._testBaseTimestamp = performance.timeOrigin / 1000;
 
-Sentry.onLoad(function () {
+Sentry.onLoad(() => {
   Sentry.init({});
 });

packages/browser-integration-tests/loader-suites/loader/onLoad/replay/init.js

@@ -1,3 +1,3 @@
-Sentry.onLoad(function () {
+Sentry.onLoad(() => {
   Sentry.init({});
 });

packages/browser-integration-tests/loader-suites/loader/onLoad/sentryOnLoadAndOnLoad/init.js

@@ -1,4 +1,4 @@
-Sentry.onLoad(function () {
+Sentry.onLoad(() => {
   // this should be called _after_ window.sentryOnLoad
   Sentry.captureException(`Test exception: ${Sentry.getCurrentHub().getClient().getOptions().tracesSampleRate}`);
 });

packages/browser-integration-tests/scripts/detectFlakyTests.ts

@@ -78,14 +78,14 @@ ${changedPaths.join('\n')}
     console.log('');
     console.log('');
 
-    console.error(`⚠️ Some tests failed.`);
+    console.error('⚠️ Some tests failed.');
     console.error(error);
     process.exit(1);
   }
 
   console.log('');
   console.log('');
-  console.log(`☑️ All tests passed.`);
+  console.log('☑️ All tests passed.');
 }
 
 function getTestPaths(): string[] {

packages/browser-integration-tests/suites/integrations/Breadcrumbs/xhr/get/subject.js

@@ -3,7 +3,7 @@ const xhr = new XMLHttpRequest();
 xhr.open('GET', 'http://localhost:7654/foo');
 xhr.send();
 
-xhr.addEventListener('readystatechange', function () {
+xhr.addEventListener('readystatechange', () => {
   if (xhr.readyState === 4) {
     Sentry.captureException('test error');
   }

packages/browser-integration-tests/suites/integrations/Breadcrumbs/xhr/post/subject.js

@@ -5,7 +5,7 @@ xhr.setRequestHeader('Accept', 'application/json');
 xhr.setRequestHeader('Content-Type', 'application/json');
 xhr.send('{"my":"body"}');
 
-xhr.addEventListener('readystatechange', function () {
+xhr.addEventListener('readystatechange', () => {
   if (xhr.readyState === 4) {
     Sentry.captureException('test error');
   }

packages/browser-integration-tests/suites/public-api/captureException/errorEvent/subject.js

@@ -1,4 +1,4 @@
-window.addEventListener('error', function (event) {
+window.addEventListener('error', event => {
   Sentry.captureException(event);
 });
 

packages/browser-integration-tests/suites/public-api/instrumentation/eventListener-wrapping/subject.js

@@ -12,7 +12,7 @@ class EventHandlerClass {
 
 const objectListener = new EventHandlerClass();
 
-window.attachListeners = function () {
+window.attachListeners = () => {
   window.addEventListener('click', functionListener);
   window.addEventListener('click', objectListener);
 };

packages/browser-integration-tests/suites/replay/errors/errorsInSession/test.ts

@@ -18,7 +18,7 @@ sentryTest(
       sentryTest.skip();
     }
 
-    let errorEventId: string = 'invalid_id';
+    let errorEventId = 'invalid_id';
 
     const reqPromise0 = waitForReplayRequest(page, 0);
     const reqPromise1 = waitForReplayRequest(page, 1);

packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestBody/test.ts

@@ -41,7 +41,7 @@ sentryTest('captures text request body', async ({ getLocalTestPath, page, browse
     xhr.open('POST', 'http://localhost:7654/foo');
     xhr.send('input body');
 
-    xhr.addEventListener('readystatechange', function () {
+    xhr.addEventListener('readystatechange', () => {
       if (xhr.readyState === 4) {
         // @ts-expect-error Sentry is a global
         setTimeout(() => Sentry.captureException('test error', 0));
@@ -122,7 +122,7 @@ sentryTest('captures JSON request body', async ({ getLocalTestPath, page, browse
     xhr.open('POST', 'http://localhost:7654/foo');
     xhr.send('{"foo":"bar"}');
 
-    xhr.addEventListener('readystatechange', function () {
+    xhr.addEventListener('readystatechange', () => {
       if (xhr.readyState === 4) {
         // @ts-expect-error Sentry is a global
         setTimeout(() => Sentry.captureException('test error', 0));
@@ -207,7 +207,7 @@ sentryTest('captures non-text request body', async ({ getLocalTestPath, page, br
     xhr.open('POST', 'http://localhost:7654/foo');
     xhr.send(body);
 
-    xhr.addEventListener('readystatechange', function () {
+    xhr.addEventListener('readystatechange', () => {
       if (xhr.readyState === 4) {
         // @ts-expect-error Sentry is a global
         setTimeout(() => Sentry.captureException('test error', 0));
@@ -288,7 +288,7 @@ sentryTest('captures text request body when matching relative URL', async ({ get
     xhr.open('POST', '/foo');
     xhr.send('input body');
 
-    xhr.addEventListener('readystatechange', function () {
+    xhr.addEventListener('readystatechange', () => {
       if (xhr.readyState === 4) {
         // @ts-expect-error Sentry is a global
         setTimeout(() => Sentry.captureException('test error', 0));
@@ -369,7 +369,7 @@ sentryTest('does not capture request body when URL does not match', async ({ get
     xhr.open('POST', 'http://localhost:7654/bar');
     xhr.send('input body');
 
-    xhr.addEventListener('readystatechange', function () {
+    xhr.addEventListener('readystatechange', () => {
       if (xhr.readyState === 4) {
         // @ts-expect-error Sentry is a global
         setTimeout(() => Sentry.captureException('test error', 0));

packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestHeaders/test.ts

@@ -45,7 +45,7 @@ sentryTest('captures request headers', async ({ getLocalTestPath, page, browserN
     xhr.setRequestHeader('X-Test-Header', 'test-value');
     xhr.send();
 
-    xhr.addEventListener('readystatechange', function () {
+    xhr.addEventListener('readystatechange', () => {
       if (xhr.readyState === 4) {
         // @ts-expect-error Sentry is a global
         setTimeout(() => Sentry.captureException('test error', 0));
@@ -132,7 +132,7 @@ sentryTest(
       xhr.setRequestHeader('X-Test-Header', 'test-value');
       xhr.send();
 
-      xhr.addEventListener('readystatechange', function () {
+      xhr.addEventListener('readystatechange', () => {
         if (xhr.readyState === 4) {
           // @ts-expect-error Sentry is a global
           setTimeout(() => Sentry.captureException('test error', 0));

packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestSize/test.ts

@@ -41,7 +41,7 @@ sentryTest('captures request body size when body is sent', async ({ getLocalTest
     xhr.open('POST', 'http://localhost:7654/foo');
     xhr.send('{"foo":"bar"}');
 
-    xhr.addEventListener('readystatechange', function () {
+    xhr.addEventListener('readystatechange', () => {
       if (xhr.readyState === 4) {
         // @ts-expect-error Sentry is a global
         setTimeout(() => Sentry.captureException('test error', 0));
@@ -132,7 +132,7 @@ sentryTest('captures request size from non-text request body', async ({ getLocal
     xhr.open('POST', 'http://localhost:7654/foo');
     xhr.send(blob);
 
-    xhr.addEventListener('readystatechange', function () {
+    xhr.addEventListener('readystatechange', () => {
       if (xhr.readyState === 4) {
         // @ts-expect-error Sentry is a global
         setTimeout(() => Sentry.captureException('test error', 0));