-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add beforeSendSpan
option
#11886
Comments
andreiborza
added a commit
that referenced
this issue
May 6, 2024
andreiborza
added a commit
that referenced
this issue
May 6, 2024
andreiborza
added a commit
that referenced
this issue
May 7, 2024
andreiborza
added a commit
that referenced
this issue
May 7, 2024
andreiborza
added a commit
that referenced
this issue
May 16, 2024
andreiborza
added a commit
that referenced
this issue
May 16, 2024
This was referenced Jun 6, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To be ready for an only-spans world, and also handle e.g. INP spans that even today are not sent in a transaction, we want to add a new option to the client:
beforeSendSpan
.This should receive a
SpanJSON
span, allowing to mutate (but not drop) this before it is sent.This should apply both for transaction events being sent (applying to all
event.spans
on the event), as well as to standalone spans sent viacreateSpanEnvelope()
.It should look something like this:
The return value will replace the original span. We will not allow to return
null
here now. The callback should run before the full event is passed tobeforeSendTransaction
.The text was updated successfully, but these errors were encountered: