Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to rewrite frame #7499

Closed
3 tasks done
zWingz opened this issue Mar 17, 2023 · 3 comments · Fixed by #7506
Closed
3 tasks done

Failed to rewrite frame #7499

zWingz opened this issue Mar 17, 2023 · 3 comments · Fixed by #7506
Assignees

Comments

@zWingz
Copy link

zWingz commented Mar 17, 2023

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using? If you use the CDN bundles, please specify the exact bundle (e.g. bundle.tracing.min.js) in your SDK setup.

@sentry/node

SDK Version

latest

Framework Version

latest

Link to Sentry event

No response

SDK Setup

No response

Steps to Reproduce

My code ran in the vscode extension and I get the frame.filename is c:\Users\Administrator\.vscode\extensions\xxxxxxx\out\extension.js
image

It doesn't match the regext /^[A-Z]:\\/, so it can't rewrite the frame

https://github.com/getsentry/sentry-javascript/blob/develop/packages/integrations/src/rewriteframes.ts#L75-L80

Expected Result

rewrite the frame correctly

Actual Result

cannot rewrite

@Lms24
Copy link
Member

Lms24 commented Mar 17, 2023

Hi @zWingz thanks for reporting! I quickly checked the regex and you're right, we're not matching on lower-case windows path prefixes. Will push a PR with the fix soon.

@Lms24
Copy link
Member

Lms24 commented Mar 17, 2023

I opened #7506 to fix this in the default iteratee of RewriteFrames. This will go out in the next release (probably on Monday).

If you need this sooner, you can write your own iteratee with the fix and provide it to the RewriteFrames constructor.

@zWingz
Copy link
Author

zWingz commented Mar 17, 2023

@Lms24 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants