Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integrations): Handle lower-case prefix windows paths in RewriteFrames #7506

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Mar 17, 2023

Our previous regex to rewrite windows file paths in stack frames didn't match lower-case c:\\ prefixes. This PR fixes that.

closes #7499

@Lms24 Lms24 requested review from mydea and AbhiPrasad March 17, 2023 13:48
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.49 KB (+0.18% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 63.56 KB (+0.3% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.11 KB (+0.24% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 56.63 KB (+0.36% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.68 KB (+0.17% 🔺)
@sentry/browser - Webpack (minified) 72.17 KB (+0.28% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.72 KB (+0.18% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 52.06 KB (+0.07% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 33.78 KB (+0.11% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.14 KB (+0.13% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44 KB (+0.33% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.07 KB (+0.35% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.22 KB (+0.27% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 55.3 KB (+0.33% 🔺)

@Lms24 Lms24 mentioned this pull request Mar 17, 2023
3 tasks
@Lms24 Lms24 merged commit 45692f4 into develop Mar 20, 2023
@Lms24 Lms24 deleted the lms/fix-rewriteframes-windows-regex branch March 20, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to rewrite frame
2 participants