Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Rage Clicks" #8300

Closed
billyvg opened this issue Jun 7, 2023 · 4 comments
Closed

Add "Rage Clicks" #8300

billyvg opened this issue Jun 7, 2023 · 4 comments
Assignees
@mydea
Labels
Package: replay

Comments

@billyvg
Copy link
Member

billyvg commented Jun 7, 2023 •
edited

The Replay SDK should track "rage" clicks (defined as 3 or more clicks within 1 second).

The breadcrumb should be similar to slow click except:

category: ui.rageClick and data = url, # of clicks, time (?)

Let's also add metric: true to the event (example] so that it gets logged in the backend.
@bruno-garcia bruno-garcia mentioned this issue Jun 7, 2023
Closed
@bruno-garcia
Copy link
Member

We plan to hide the breadcrumbs from the UI for a bit while we figure out the ideal detection logic to avoid alarm on false positives:

@mydea
Copy link
Member

mydea commented Jun 9, 2023

Hmm, I wonder if 3 is too low as a threshold. From watching e.g. my grandparents use a computer, I see them triple-clicking (instead of double clicking) stuff quite often... Maybe we should start at 4+ as a threshold?

Also note that tripple clicking in a text field actually selects all content/the paragraph, so this would also def. result in a false positive 😅

@mydea mydea mentioned this issue Jun 9, 2023
Closed
@mydea mydea self-assigned this Jun 12, 2023
@billyvg
Copy link
Member Author

billyvg commented Jun 13, 2023

@mydea Since there's some unknown/disagreements with the timings, let's add this as an experiment.

@mydea mydea mentioned this issue Jun 13, 2023
Merged
mydea added a commit that referenced this issue Jun 16, 2023
@mydea
feat(replay): Rework slow click & multi click detection (#8322)
dba9a3d 
This PR reworks the slow click detection to accommodate rage click
detection as well.
This required substantial changes, as we need to keep track of stuff
much more.

Now, we keep a list of clicks that come in in a new class. We register a
single set of listeners (mutation observer, click listener, scroll
listener), and then try to route things to the correct clicks as much as
possible.

Any clicks within 1 second count as "multi click", so are not considered
for slow clicks at all, but counted on the first click. After a second,
a click (even on the same element) will be treated as a "new" click.

ref #8300
@mydea mydea mentioned this issue Jun 22, 2023
Closed
@bruno-garcia
Copy link
Member

We'll close this through resolving: #8379

@mydea mydea closed this as completed Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mydea mydea

Labels
Package: replay
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(replay): Detect rage click (WIP) getsentry/sentry-javascript
3 participants
@billyvg @bruno-garcia @mydea