-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve slow click / multi click capture #8379
Comments
Related to #8300 |
If we use the flowchart (which is great btw) in any official capacity, we should clarify this point on there that it is specific to the element.
👍
Will we still have |
Good point! I can update this, to be clear.
Yes, this works exactly the same as before, we only wait for 7s even if we detect a mutation before. |
One thing to note, which may or may not be unexpected, is that a single click can contribute to multiple Imagine a sequence like this:
--> For A, we'd create a I think this is OK (and avoiding this becomes very difficult, because we'd need to keep track of where a click was counted etc.), but it's something to keep in mind when evaluating multi clicks. |
Ah, I was under the impression it would only count clicks on that specific element.. I can see a case for both scenarios |
amazing chart, it's very clear! I think that the timer output at 11s should have a count of 3. there are counts of 0s, 0.5s and 4s leading into it.
|
It does count only on this specific element, but even on one element this can happen!
With the current implementation, the click that happens at 4s will have clickCount: 4, because starting with & including this there are 4 clicks from there until 4+7s. |
Implements the changes outlined in #8379
After some discussion, we landed on implementing the following logic/behavior for slow/rage click detection in Replay:
ui.click
breadcrumbs immediatelyui.click
breadcrumb!ui.click
breadcrumb is captured, we start looking for 7s for a) further clicks on the same element and b) if the click is a slow clickui.slowClickDetected
breadcrumb with aclickCount
counting all clicks on the same element in the last 7sui.multiClick
breadcrumb with theclickCount
This means that:
continue
button that is clicked a few times in 7s because the user is moving forward fast - but this we can figure out eventually.One thing to note is that the
ui.slowClick
/ui.multiClick
breadcrumbs will be created with the same timestamp & message as the originalui.click
breadcrumb.The text was updated successfully, but these errors were encountered: