Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Replay] Ensure we check replay session before adding replay_id to errors #9106

Closed
mydea opened this issue Sep 25, 2023 · 0 comments · Fixed by #9109
Closed

[Replay] Ensure we check replay session before adding replay_id to errors #9106

mydea opened this issue Sep 25, 2023 · 0 comments · Fixed by #9109
Assignees
Labels
Package: replay Issues related to the Sentry Replay SDK Type: Bug

Comments

@mydea
Copy link
Member

mydea commented Sep 25, 2023

Currently, if you look e.g. at this issue: https://sentry.sentry.io/replays/04147ee7b3684015a60d6d951f4a4303/?project=11276&query=&referrer=%2Freplays%2F&statsPeriod=7d&t_main=errors&yAxis=count%28%29 you can see that the error gets the replay_id added even though the session is for sure expired.

We should check in the error handler if the session is expired before attaching the replay_id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK Type: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant