-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(core): Remove transaction name extraction from requestDataIntegration
#11513
Merged
lforst
merged 7 commits into
develop
from
lms/feat-remove-transactionName-from-requestDataIntegration
Apr 25, 2024
Merged
ref(core): Remove transaction name extraction from requestDataIntegration
#11513
lforst
merged 7 commits into
develop
from
lms/feat-remove-transactionName-from-requestDataIntegration
Apr 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
…ansactionName-from-requestDataIntegration
requestDataIntegration
mydea
reviewed
Apr 25, 2024
@@ -67,12 +66,11 @@ const _requestDataIntegration = ((options: RequestDataIntegrationOptions = {}) = | |||
|
|||
return { | |||
name: INTEGRATION_NAME, | |||
processEvent(event, _hint, client) { | |||
processEvent(event, _hint, _client) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
processEvent(event, _hint, _client) { | |
processEvent(event) { |
mydea
reviewed
Apr 25, 2024
@@ -166,15 +133,3 @@ function convertReqDataIntegrationOptsToAddReqDataOpts( | |||
}, | |||
}; | |||
} | |||
|
|||
function getSDKName(client: Client): string | undefined { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we even do this before here 😅 but I guess it is just not needed because we always set this directly now, right?
mydea
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed two places where we assign
event.transaction
let's see how badly this nukes CI 👀