Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(react-router): Make RouteProps typing more generic #3570

Merged
merged 2 commits into from
May 19, 2021
Merged

ref(react-router): Make RouteProps typing more generic #3570

merged 2 commits into from
May 19, 2021

Commits on May 19, 2021

  1. ref(react-router): Make RouteProps typing more generic 

    Previously we copied over the typings for a react-router Route props.
This means though that when the react-router updates it's types,
there is a chance our types will break. To avoid this in the future,
this patch removes the RouteProps typing and uses a plain
`Record<string, any>` type instead.

The props we do leverage from the RouteProps have checks in the code
and there are tests covering that the RouteProps properties exist,
so making the type more generic is not that risky.
    @AbhiPrasad
    AbhiPrasad committed May 19, 2021
    Configuration menu
    Copy the full SHA
    a2e1ee5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into abhi/location-typing-react-router

    @AbhiPrasad
    AbhiPrasad committed May 19, 2021
    Configuration menu
    Copy the full SHA
    9253417 View commit details
    Browse the repository at this point in the history