ref(react-router): Make RouteProps typing more generic #3570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we copied over the typings for a react-router Route props. This means though that when the react-router updates it's types, there is a chance our types will break. To avoid this in the future, this patch removes the RouteProps typing and uses a plain `Record<string, any>` type instead. The props we do leverage from the RouteProps have checks in the code and there are tests covering that the RouteProps properties exist, so making the type more generic is not that risky.
size-limit report
|
rhcarvalho
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3550
Previously we copied over the typings for a react-router Route props.
This means though that when the react-router updates it's types,
there is a chance our types will break. To avoid this in the future,
this patch removes the RouteProps typing and uses a plain
Record<string, any>type instead.The props we do leverage from the RouteProps have checks in the code
and there are tests covering that the RouteProps properties exist,
so making the type more generic is not that risky.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).