ref(tracing): Extract propagation context from meta tags #8430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
a team,
stephanie-anderson and
lforst
and removed request for
a team
size-limit report 📦
|
|
This PR address the tracing tests stuff: #8431 |
Lms24
approved these changes
Jun 30, 2023
| @@ -214,7 +214,7 @@ export function shouldAttachHeaders(url: string, tracePropagationTargets: (strin | |||
| * | |||
| * @returns Span if a span was created, otherwise void. | |||
| */ | |||
| function fetchCallback( | |||
| export function fetchCallback( | |||
There was a problem hiding this comment.
It was because this was actually being imported by tests:
| @@ -364,7 +364,7 @@ export function addTracingHeadersToFetchRequest( | |||
| * | |||
| * @returns Span if a span was created, otherwise void. | |||
| */ | |||
| function xhrCallback( | |||
| export function xhrCallback( | |||
AbhiPrasad
added a commit
that referenced
this pull request
Jul 1, 2023
Building on top of #8430, this PR makes a quick fix to make sure we are running unit tests for `@sentry-internal/eslint-plugin`, `@sentry-internal/tracing`, and `@sentry-internal/replay-worker`. This was found not to be running before because we had a blanket `--ignore @sentry-internal/*` when making lerna run tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #8352
This PR makes sure the
BrowserTracingintegration updates the propagation context based on meta tags. To ensure we don't keep the same propagation context, we continuously update it every time a route change should happen (navigation).Note that we have a bunch of test changes here. This is because we actually weren't running any of the tracing tests in CI because of a blanket ignore we use (this logic is all in
@sentry-internal/tracing. I'm fixing this in a follow up PR.sentry-javascript/package.json
Lines 28 to 29 in e02c27f