Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make sure we run sentry-internal unit tests #8431

Merged
merged 13 commits into from
Jul 1, 2023

Conversation

AbhiPrasad
Copy link
Member

Building on top of #8430, this PR makes a quick fix to make sure we are running unit tests for @sentry-internal/eslint-plugin, @sentry-internal/tracing, and @sentry-internal/replay-worker. This was found not to be running before because we had a blanket --ignore @sentry-internal/* when making lerna run tests.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.79 KB (+0.08% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 68.55 KB (+0.16% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 20.1 KB (+0.09% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 59.79 KB (+0.14% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.71 KB (+0.12% 🔺)
@sentry/browser - Webpack (minified) 70.93 KB (+0.14% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.73 KB (+0.07% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 50.22 KB (-0.09% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 29.76 KB (-0.02% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 27.82 KB (-0.07% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 49.44 KB (+0.02% 🔺)
@sentry/replay - Webpack (gzipped + minified) 43.12 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 69.2 KB (-0.03% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.66 KB (+0.03% 🔺)

@mydea
Copy link
Member

mydea commented Jun 30, 2023

One more reason to finally tackle #6711 😅 this is basically exactly this, we want to not run really private tests but run tests for internal packages. But for now this is a good fix.

Base automatically changed from abhi-twp-browsertracing to develop June 30, 2023 14:23
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) June 30, 2023 16:39
@AbhiPrasad AbhiPrasad merged commit 16a29c0 into develop Jul 1, 2023
66 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-tracing-internal-tests branch July 1, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants