Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(replay): Better session storage check #8547

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix(replay): Better session storage check #8547

merged 1 commit into from
Jul 17, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Jul 17, 2023

Apparently accessing sessionStorage in an iframe with certain permissions can result in a throw, so we try-catch this to ensure we do not produce any errors.

Closes #8392

@mydea mydea added Type: Bug Package: replay Issues related to the Sentry Replay SDK labels Jul 17, 2023
@mydea mydea requested review from billyvg and Lms24 July 17, 2023 08:15
@mydea mydea self-assigned this Jul 17, 2023
@mydea mydea mentioned this pull request Jul 17, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.95 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 69.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 20.28 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 60.38 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.9 KB (0%)
@sentry/browser - Webpack (minified) 71.51 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.92 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 50.58 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 30.11 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 28.16 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 49.43 KB (+0.02% 🔺)
@sentry/replay - Webpack (gzipped + minified) 43.1 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 69.51 KB (+0.01% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.83 KB (+0.02% 🔺)

@mydea mydea force-pushed the fn/fix-replay-sessionStorage-check branch from 6cc56c4 to c688bba Compare July 17, 2023 11:42
@mydea mydea merged commit 6444b34 into develop Jul 17, 2023
61 checks passed
@mydea mydea deleted the fn/fix-replay-sessionStorage-check branch July 17, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@billyvg billyvg Awaiting requested review from billyvg

Assignees

@mydea mydea

Labels
Package: replay Issues related to the Sentry Replay SDK Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replay: Gracefully degrade if sessionStorage isn't available
2 participants
@mydea @Lms24