Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Use globalThis instead of global in edge runtime #9612

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

powerfulyang
Copy link
Contributor

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

9f32c61#diff-55396f0a8f12ba2eb7ce27f3cf886f946c29c2aa93b5d2f993dadbd5a9f3cc75L979

Due to this commit, sentry.edge.config.js is added. But global doesn't exist in edge runtime, so we should use globalThis.

Error Msg:
image

@mydea mydea requested a review from lforst November 21, 2023 08:10
@lforst lforst changed the title fix(nextjs): use globalThis instead of global fix(nextjs): Use globalThis instead of global in edge runtime Nov 21, 2023
@lforst lforst merged commit b8c46ea into getsentry:develop Nov 21, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants