Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uptime): Allow request_info and http_status_code to be null #303

Conversation

evanpurkhiser
Copy link
Member

No description provided.

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner June 6, 2024 23:50
Copy link

github-actions bot commented Jun 6, 2024

versions in use:

The following repositories use one of the schemas you are editing. It is recommended to roll out schema changes in small PRs, meaning that if those used versions lag behind the latest, it is probably best to update those services before rolling out your change.

  • getsentry/sentry: pip:sentry-kafka-schemas==0.1.90

latest version: 0.1.90

benign changes

schemas/uptime-results.v1.schema.json

  • {"path": ".request_info", "change": {"TypeAdd": {"added": "null"}}}
    

✅ This PR should be safe to roll out to consumers first. Make sure to bump
the library in the following repos first:

getsentry/sentry

...then in the other repos:

getsentry/uptime-checker

Take a look at the README for how to release a new version of sentry-kafka-schemas.

Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh makes sense, we might not have request_info for miss status, 👍

@evanpurkhiser evanpurkhiser merged commit 240729c into main Jun 6, 2024
14 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/fix-uptime-allow-request-info-and-http-status-code-to-be-null branch June 6, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants