Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing breadcrumbs from views #399

Merged
merged 1 commit into from Oct 12, 2020

Conversation

stayallive
Copy link
Collaborator

@stayallive stayallive commented Oct 9, 2020

I noticed the breadcrumbs created from views were discarded because of the scope push/pop.

I am not sure this is better but it does work better, I'd appreciate some feedback if this sounds logical but this does seem more "correct".

@stayallive stayallive requested a review from HazAT Oct 9, 2020
@stayallive stayallive marked this pull request as ready for review Oct 9, 2020
HazAT
HazAT approved these changes Oct 9, 2020
@stayallive stayallive merged commit 722f6eb into master Oct 12, 2020
2 checks passed
@stayallive stayallive deleted the feature/fix-missing-breadcrumbs-from-views branch Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants