Queue integration fixes #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stayallive
commented
Jun 4, 2024
| @@ -68,6 +68,7 @@ public function onBoot(Dispatcher $events): void | |||
| ->setOp(self::QUEUE_SPAN_OP_QUEUE_PUBLISH) | |||
| ->setData([ | |||
| 'messaging.system' => 'laravel', | |||
| 'messaging.message.id' => $payload['uuid'] ?? null, | |||
| 'messaging.destination.name' => $queue, | |||
There was a problem hiding this comment.
This is prepended with "queue:" to something like: queues:queue-name
We need to "fix" this because otherwise the published are on the wrong destination.
There was a problem hiding this comment.
Turns out... only the Redis driver does this. We could argue Laravel should fix this but let's also fix it ourselfs 😄
cleptric
reviewed
Jun 4, 2024
| 'messaging.message.id' => (string) $event->job->getJobId(), | ||
|
|
||
| 'messaging.message.id' => $jobPayload['uuid'] ?? $event->job->getJobId(), |
There was a problem hiding this comment.
We need to keep the string cast for $event->job->getJobId().
There was a problem hiding this comment.
It's documented as returning a string? When doesn't it do that?
Maybe we should just rely on $jobPayload['uuid'] anyway otherwise they will never match. Laravel should always add a ID to the job payload. Not sure if it's possible to not have one.
cleptric
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$job->getJobId()is publisher (like SQS) ID)queues:prefix for queue names when using Redis driver