Encapsulate the event ID into its own value object #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
approved these changes
May 6, 2020
stayallive
approved these changes
May 6, 2020
Jean85
requested changes
May 7, 2020
ste93cry
force-pushed
the
feature/event-id-value-object
branch
from
c7c4b71
to
fd9ae4c
Compare
Jean85
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactor to start encapsulating the ID of an event inside its own value object. The idea behind this change is to typehint this information in
3.0in all methods that accepts or returns it instead of accepting a genericstringvalue that noone can guarantee to be valid without validating it every time