Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the deprecated returning of an event ID as a string instead of as a value object #1036

Conversation

ste93cry
Copy link
Collaborator

@ste93cry ste93cry commented Jul 3, 2020

Q A
Branch? 3.0
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
License MIT

This PR cleanups the codebase from the deprecations triggered by #1013

@ste93cry ste93cry added this to the 3.0 milestone Jul 3, 2020
@ste93cry ste93cry force-pushed the feature/cleanup-deprecated-event-id-as-string-return-type branch 2 times, most recently from d1b0da8 to cb06986 Compare July 4, 2020 00:24
Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍 only comment is on the upgrade doc.

UPGRADE-3.0.md Show resolved Hide resolved
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@ste93cry ste93cry force-pushed the feature/cleanup-deprecated-event-id-as-string-return-type branch from cb06986 to de7de4f Compare July 6, 2020 18:19
@ste93cry ste93cry force-pushed the feature/cleanup-deprecated-event-id-as-string-return-type branch from de7de4f to 34a68b9 Compare July 6, 2020 18:25
@ste93cry ste93cry merged commit 2e329d5 into getsentry:3.x Jul 6, 2020
@ste93cry ste93cry deleted the feature/cleanup-deprecated-event-id-as-string-return-type branch July 6, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants