Skip to content

Commit

Permalink
Linked GH issue in comment
Browse files Browse the repository at this point in the history
  • Loading branch information
antonpirker committed May 10, 2024
1 parent 7adb5a1 commit 7232c44
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions sentry_sdk/integrations/redis/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ def sentry_patched_execute_command(self, name, *args, **kwargs):
# Questions:
# -) We should probablby have the OP.DB_REDIS span and a separate OP.CACHE_GET_ITEM (or set_item) span, right?
# -) We probably need to research what redis commands are used by caching libs.
# GitHub issue: https://github.com/getsentry/sentry-python/issues/2965
with sentry_sdk.start_span(op=OP.DB_REDIS, description=description) as span:
set_db_data_fn(span, self)
_set_client_data(span, is_cluster, name, *args)
Expand Down
1 change: 1 addition & 0 deletions sentry_sdk/integrations/redis/asyncio.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ async def _sentry_execute_command(self, name, *args, **kwargs):
# Questions:
# -) We should probablby have the OP.DB_REDIS span and a separate OP.CACHE_GET_ITEM (or set_item) span, right?
# -) We probably need to research what redis commands are used by caching libs.
# GitHub issue: https://github.com/getsentry/sentry-python/issues/2965
with sentry_sdk.start_span(op=OP.DB_REDIS, description=description) as span:
set_db_data_fn(span, self)
_set_client_data(span, is_cluster, name, *args)
Expand Down

0 comments on commit 7232c44

Please sign in to comment.