Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce config for MAX_STRING_LENGTH #2121

Closed
puittenbroek opened this issue May 17, 2023 · 6 comments · Fixed by #2171
Closed

Introduce config for MAX_STRING_LENGTH #2121

puittenbroek opened this issue May 17, 2023 · 6 comments · Fixed by #2171
Labels
enhancement New feature or request

Comments

@puittenbroek
Copy link
Contributor

puittenbroek commented May 17, 2023

Problem Statement

In our on-premises Sentry, we're regularly missing some context information (variables, part of variables) in our issues. This is quite annoying since they usually contain ID or hashes that we need to further debug the information.
We want to raise the limit that the Sentry SDK sends. But that limit is hard coded.

There is a nice TODO, saying it should be read from config, but I cannot find any issues regarding that.

So the only solution would be monkeypatching this value. Which I consider the source of (all) evil and should be avoided, especially in production environment.

Solution Brainstorm

  1. Introduce a config for MAX_STRING_LENGTH
  2. Read MAX_STRING_LENGTH from said config
  3. Optional: Document said config with a disclaimer that you can/will break Sentry internals if you raise this limit to a too high value (assumption, I'm sure it's set to it's current value for a reason)
@puittenbroek puittenbroek added the enhancement New feature or request label May 17, 2023
@antonpirker
Copy link
Member

Hey @puittenbroek !

Sounds like a good suggestion.
What do you think, do you want to give it a go and submit a PR?

@puittenbroek
Copy link
Contributor Author

I'll try and squeeze it in between things :)

@github-actions
Copy link

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@puittenbroek
Copy link
Contributor Author

Spent some time on a PR, let me know what you think.

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@puittenbroek
Copy link
Contributor Author

Bump

antonpirker added a commit that referenced this issue Jul 19, 2023
---------

Co-authored-by: Peter Uittenbroek <peter.uittenbroek@xs2event.com>
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Co-authored-by: Anton Pirker <anton.pirker@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants