Read MAX_VALUE_LENGTH from client options (#2121)

[puittenbroek]

Hard to jump through some hoops to get the new client options for max_string_length to where it was needed.

Still kept a fallback in place since I'm unsure if client options is always available/passed a long.

Closes #2121

[puittenbroek]

@antonpirker do you have time to review this? Or someone else from your team?

[sentrivana]

Hey @puittenbroek, thanks a lot for this PR! We're currently evaluating internally what the potential impact of this change would be with regards to the ingestion pipeline -- we'll get back to you soon.

[sentrivana]

@puittenbroek I ran the pipeline in the meantime -- could you please take a look at the failing workflows?

I'll squeeze a review in sometime next week unless Anton beats me to it. We'll also need docs (source) for this where we explicitly warn users that bumping the string limit might result in event payloads getting too big and events getting dropped, but I can take care of writing that.

[puittenbroek]

The circular import in apidocs is a PITA, because the consts file imports from sentry_sdk.integrations import Integration which itself also imports which need the consts file. Only way around that is putting my new constant at the top of the file.

[antonpirker]

Have some questions. In general it looks really good!

[antonpirker]

Great work @puittenbroek !
I have left a couple of questions/suggestions.
We then have to fix eventually failing tests and add the new option to the docs repo.

[antonpirker]

Added docs PR here: getsentry/sentry-docs#7465

[antonpirker]

I just discovered that we already have an option "max_value_length" in the PHP sdk, so I will rename the option to be in line with the other SDK.

[antonpirker]

lgtm

[puittenbroek]

I just discovered that we already have an option "max_value_length" in the PHP sdk, so I will rename the option to be in line with the other SDK.

Makes sense :) And thanks for the docs PR! pretty swamped at work so didn't have much time to pick this up further.

[antonpirker]

No problem @puittenbroek !
Thanks again for the contribution, I guess we are now ready to merge this!