Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Rename MYPY to TYPE_CHECKING #1934

Merged
merged 4 commits into from
Mar 3, 2023
Merged

fix: Rename MYPY to TYPE_CHECKING #1934

merged 4 commits into from
Mar 3, 2023

Commits on Mar 1, 2023

  1. fix: Rename MYPY to TYPE_CHECKING 

    we have a lot of conditionals in our codebase that are supposed to
separate the code that mypy is supposed to see from the code that we
actually want to execute.

In the specific case of sentry_sdk.configure_scope, this means that
pyright does not handle with the overloads correctly because it only
recognizes TYPE_CHECKING as a special variable name, not MYPY.

Rename MYPY to TYPE_CHECKING so pyright typechecks configure_scope
correctly.
    @untitaker
    untitaker committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    997e0c7 View commit details
    Browse the repository at this point in the history

  2. reexport old alias

    @untitaker
    untitaker committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    16d9c8e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fix/mypy-typechecking

    @untitaker
    untitaker committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    81928d0 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. Merge remote-tracking branch 'origin/master' into fix/mypy-typechecking

    @untitaker
    untitaker committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    20adc12 View commit details
    Browse the repository at this point in the history